It'll most likely be: virtual void isPlayingAudioDidChange(bool) to match the bool isPlayingAudio() const; we are adding to WebCore::Page. See https://bugs.webkit.org/show_bug.cgi?id=137218.
Created attachment 239344 [details] Patch
Comment on attachment 239344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review r=me, with nit. > Source/WebCore/page/ChromeClient.h:434 > + virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { } Nit: You don't need to include the (commented out) parameter name here. It's obvious from the function name.
(In reply to comment #2) > (From update of attachment 239344 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review > > r=me, with nit. > > > Source/WebCore/page/ChromeClient.h:434 > > + virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { } > > Nit: You don't need to include the (commented out) parameter name here. It's obvious from the function name. I'll remove it. Thanks for the review!
Committed: https://trac.webkit.org/changeset/174365