Bug 137050 - Call WKPageUIClient::isPlayingAudioDidChange() whenever audio starts/stops playing on a page
Summary: Call WKPageUIClient::isPlayingAudioDidChange() whenever audio starts/stops pl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on: 137220
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-23 16:26 PDT by Ada Chan
Modified: 2014-10-06 21:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.27 KB, patch)
2014-10-06 14:47 PDT, Ada Chan 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2014-09-23 16:26:58 PDT 
Call WKPageUIClient::isPlayingAudioDidChange() whenever audio starts/stops playing on a page.
Comment 1 Alexey Proskuryakov 2014-09-23 19:21:07 PDT 
Will this include plug-in audio?
Comment 2 Ada Chan 2014-09-23 19:31:58 PDT 
Yes it will include plug-in audio.  I'll most likely separate that into a different bug later though.
Comment 3 Ada Chan 2014-10-06 14:40:17 PDT 
(In reply to comment #2)
> Yes it will include plug-in audio.  I'll most likely separate that into a different bug later though.

I've filed:

https://bugs.webkit.org/show_bug.cgi?id=137219 for handling plug-in audio.
https://bugs.webkit.org/show_bug.cgi?id=137464 for handling web audio.
Comment 4 Ada Chan 2014-10-06 14:47:28 PDT 
Created attachment 239358 [details]
Patch
Comment 5 Ada Chan 2014-10-06 21:43:02 PDT 
Committed:
https://trac.webkit.org/changeset/174384