WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137103
Use is<HTML*Element>() instead of isHTML*Element() - Part 2
https://bugs.webkit.org/show_bug.cgi?id=137103
Summary
Use is<HTML*Element>() instead of isHTML*Element() - Part 2
Chris Dumez
Reported
2014-09-24 20:31:41 PDT
Use is<HTML*Element>() instead of isHTML*Element() and drop support for the generated isHTML*Element() macros.
Attachments
Patch
(120.14 KB, patch)
2014-09-24 21:46 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(119.97 KB, patch)
2014-09-25 10:29 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(119.97 KB, patch)
2014-09-25 10:30 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(126.32 KB, patch)
2014-09-25 15:17 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(127.08 KB, patch)
2014-09-25 15:36 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2014-09-24 21:46:51 PDT
Created
attachment 238640
[details]
Patch
Csaba Osztrogonác
Comment 2
2014-09-25 04:00:15 PDT
Comment on
attachment 238640
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=238640&action=review
> Source/WebCore/css/CSSStyleSheet.cpp:39 > +#include "SVGStyleElement.H"
SVGStyleElement.H -> SVGStyleElement.h
Chris Dumez
Comment 3
2014-09-25 10:29:30 PDT
Created
attachment 238662
[details]
Patch
Chris Dumez
Comment 4
2014-09-25 10:30:57 PDT
Created
attachment 238663
[details]
Patch
Chris Dumez
Comment 5
2014-09-25 13:50:22 PDT
(In reply to
comment #2
)
> (From update of
attachment 238640
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=238640&action=review
> > > Source/WebCore/css/CSSStyleSheet.cpp:39 > > +#include "SVGStyleElement.H" > > SVGStyleElement.H -> SVGStyleElement.h
Thanks, fixed.
Benjamin Poulain
Comment 6
2014-09-25 15:02:41 PDT
Comment on
attachment 238663
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=238663&action=review
> Source/WebCore/css/CSSDefaultStyleSheets.cpp:65 > static inline bool elementCanUseSimpleDefaultStyle(Element* e)
The argument should be a reference. "e" should be element.
> Source/WebCore/html/HTMLNameCollection.cpp:54 > + return is<HTMLImageElement>(element) || is<HTMLFormElement>(element) || element.hasTagName(appletTag)
I guess element.hasTagName(appletTag) is one of the special case?
Chris Dumez
Comment 7
2014-09-25 15:04:34 PDT
Comment on
attachment 238663
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=238663&action=review
>> Source/WebCore/html/HTMLNameCollection.cpp:54 >> + return is<HTMLImageElement>(element) || is<HTMLFormElement>(element) || element.hasTagName(appletTag) > > I guess element.hasTagName(appletTag) is one of the special case?
No, I missed it :)
Chris Dumez
Comment 8
2014-09-25 15:17:59 PDT
Created
attachment 238677
[details]
Patch
Chris Dumez
Comment 9
2014-09-25 15:36:54 PDT
Created
attachment 238678
[details]
Patch
WebKit Commit Bot
Comment 10
2014-09-25 16:37:18 PDT
Comment on
attachment 238678
[details]
Patch Clearing flags on attachment: 238678 Committed
r173980
: <
http://trac.webkit.org/changeset/173980
>
WebKit Commit Bot
Comment 11
2014-09-25 16:37:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug