Bug 137015 – Add support for is<HTML*Element>() for type checking

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Add support for is<HTML*Element>() for casting, while supporting the legacy toHTML*Element() form until the code base is fully ported to the new type checking helper.

[Chris Dumez]

Created attachment 238507 [details]
Patch

[Chris Dumez]

Created attachment 238509 [details]
Patch

[Chris Dumez]

Created attachment 238510 [details]
Patch

[Chris Dumez]

Created attachment 238513 [details]
Patch

[Benjamin Poulain]

Comment on attachment 238513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238513&action=review

rs=me

> Source/WebCore/dom/Element.h:679
> +// Type checking function for Elements, to use before casting
> +// with downcast<>().

This should be on a one line.

> Source/WebCore/dom/make_names.pl:647
> +    static bool checkTagName(const HTMLElement& element) { return !element.isHTMLUnknownElement() && element.hasTagName($parameters{namespace}Names::${name}Tag); }

It's really a shame we need isHTMLUnknownElement(). It'd be nice if you find a way to remove it.

[Chris Dumez]

Created attachment 238580 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 238580 [details]
Patch

Clearing flags on attachment: 238580

Committed r173907: <http://trac.webkit.org/changeset/173907>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.