Bug 136399 - DOMTimer::m_nestingLevel is prone to overflow
Summary: DOMTimer::m_nestingLevel is prone to overflow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-29 17:21 PDT by Gavin Barraclough
Modified: 2014-08-29 21:35 PDT (History)
0 users

See Also:

Attachments
Fix (4.72 KB, patch)
2014-08-29 17:41 PDT, Gavin Barraclough 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-08-29 17:21:39 PDT 
Since this would happen after the 2 billionth timer fire this is unlikely, and consequences aren't severe (breaks throttling).
Comment 1 Gavin Barraclough 2014-08-29 17:41:18 PDT 
Created attachment 237395 [details]
Fix
Comment 2 Alexey Proskuryakov 2014-08-29 18:02:28 PDT 
Comment on attachment 237395 [details]
Fix

Not related to this patch, but looks like we have a thread safety issue with nestingLevel and workers.
Comment 3 Gavin Barraclough 2014-08-29 18:13:16 PDT 
Transmitting file data ..
Committed revision 173132.
Comment 4 Gavin Barraclough 2014-08-29 21:35:24 PDT 
(In reply to comment #2)
> (From update of attachment 237395 [details])
> Not related to this patch, but looks like we have a thread safety issue with nestingLevel and workers.

Good point! Fixed in: https://bugs.webkit.org/show_bug.cgi?id=136401