Bug 136401 - Make timerNestingLevel threadsafe
Summary: Make timerNestingLevel threadsafe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-29 18:17 PDT by Gavin Barraclough
Modified: 2014-08-29 18:33 PDT (History)
3 users (show)

See Also:

Attachments
Fix (4.22 KB, patch)
2014-08-29 18:19 PDT, Gavin Barraclough 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-08-29 18:17:00 PDT 
timerNestingLevel, used by DOMTimer to determine whether a timer is 'nested' (repeating, possible due to a timer rescheduling itself) is a global. Since worker threads can set timers too this is not thread safe.
Comment 1 Gavin Barraclough 2014-08-29 18:19:18 PDT 
Created attachment 237401 [details]
Fix
Comment 2 Gavin Barraclough 2014-08-29 18:33:40 PDT 
Transmitting file data ....
Committed revision 173133.