RESOLVED FIXED 136196
build.webkit.org/dashboard: Add a metrics page with overall bot performance results
https://bugs.webkit.org/show_bug.cgi?id=136196
Summary build.webkit.org/dashboard: Add a metrics page with overall bot performance r...
Alexey Proskuryakov
Reported 2014-08-23 19:53:09 PDT
I'd like to display results such as: - how often are bots red? - how long does it take from landing a patch to getting results from bots?
Attachments
choose date range (106.11 KB, image/png)
2014-08-23 20:05 PDT, Alexey Proskuryakov
no flags
results (89.98 KB, image/png)
2014-08-23 20:05 PDT, Alexey Proskuryakov
no flags
scrolled down to reveal platforms (274.56 KB, image/png)
2014-08-23 20:06 PDT, Alexey Proskuryakov
no flags
proposed patch (212.58 KB, patch)
2014-08-23 20:08 PDT, Alexey Proskuryakov
no flags
proposed patch (212.86 KB, patch)
2014-08-25 10:47 PDT, Alexey Proskuryakov
no flags
proposed patch (213.00 KB, patch)
2014-08-26 23:45 PDT, Alexey Proskuryakov
no flags
proposed patch (212.96 KB, patch)
2014-08-26 23:46 PDT, Alexey Proskuryakov
timothy: review+
Alexey Proskuryakov
Comment 1 2014-08-23 20:05:30 PDT
Created attachment 237035 [details] choose date range
Alexey Proskuryakov
Comment 2 2014-08-23 20:05:53 PDT
Alexey Proskuryakov
Comment 3 2014-08-23 20:06:20 PDT
Created attachment 237037 [details] scrolled down to reveal platforms
Alexey Proskuryakov
Comment 4 2014-08-23 20:08:53 PDT
Created attachment 237038 [details] proposed patch
Alexey Proskuryakov
Comment 5 2014-08-25 10:47:28 PDT
Created attachment 237093 [details] proposed patch With a small fix to avoid an assertion when date picker returns an invalid date.
Alexey Proskuryakov
Comment 6 2014-08-26 23:45:16 PDT
Created attachment 237210 [details] proposed patch Changes from previous version: 1. Applied the fix for bug 136282 (would be nice to share this code between regular dashboard and the metrics page). 2. Now that we have branch support enabled on Trac, ignore non-trunk commits for better accuracy.
Alexey Proskuryakov
Comment 7 2014-08-26 23:46:28 PDT
Created attachment 237211 [details] proposed patch Uploaded a wrong version.
Timothy Hatcher
Comment 8 2014-08-27 07:43:44 PDT
Comment on attachment 237211 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=237211&action=review Looks great! > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:51 > + if (queue.builder) { > + categoryName = "builders"; > + } else if (queue.tester) { > + categoryName = queue.testCategory; > + } else { Can drop the braces.
Alexey Proskuryakov
Comment 9 2014-08-27 10:14:42 PDT
Note You need to log in before you can comment on or make changes to this bug.