Bug 136196 - build.webkit.org/dashboard: Add a metrics page with overall bot performance results
Summary: build.webkit.org/dashboard: Add a metrics page with overall bot performance r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 136195
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-23 19:53 PDT by Alexey Proskuryakov
Modified: 2014-08-27 10:14 PDT (History)
4 users (show)

See Also:


Attachments
choose date range (106.11 KB, image/png)
2014-08-23 20:05 PDT, Alexey Proskuryakov
no flags Details
results (89.98 KB, image/png)
2014-08-23 20:05 PDT, Alexey Proskuryakov
no flags Details
scrolled down to reveal platforms (274.56 KB, image/png)
2014-08-23 20:06 PDT, Alexey Proskuryakov
no flags Details
proposed patch (212.58 KB, patch)
2014-08-23 20:08 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (212.86 KB, patch)
2014-08-25 10:47 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (213.00 KB, patch)
2014-08-26 23:45 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (212.96 KB, patch)
2014-08-26 23:46 PDT, Alexey Proskuryakov
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-08-23 19:53:09 PDT
I'd like to display results such as:

- how often are bots red?
- how long does it take from landing a patch to getting results from bots?
Comment 1 Alexey Proskuryakov 2014-08-23 20:05:30 PDT
Created attachment 237035 [details]
choose date range
Comment 2 Alexey Proskuryakov 2014-08-23 20:05:53 PDT
Created attachment 237036 [details]
results
Comment 3 Alexey Proskuryakov 2014-08-23 20:06:20 PDT
Created attachment 237037 [details]
scrolled down to reveal platforms
Comment 4 Alexey Proskuryakov 2014-08-23 20:08:53 PDT
Created attachment 237038 [details]
proposed patch
Comment 5 Alexey Proskuryakov 2014-08-25 10:47:28 PDT
Created attachment 237093 [details]
proposed patch

With a small fix to avoid an assertion when date picker returns an invalid date.
Comment 6 Alexey Proskuryakov 2014-08-26 23:45:16 PDT
Created attachment 237210 [details]
proposed patch

Changes from previous version:
1. Applied the fix for bug 136282 (would be nice to share this code between regular dashboard and the metrics page).
2. Now that we have branch support enabled on Trac, ignore non-trunk commits for better accuracy.
Comment 7 Alexey Proskuryakov 2014-08-26 23:46:28 PDT
Created attachment 237211 [details]
proposed patch

Uploaded a wrong version.
Comment 8 Timothy Hatcher 2014-08-27 07:43:44 PDT
Comment on attachment 237211 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237211&action=review

Looks great!

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:51
> +        if (queue.builder) {
> +            categoryName = "builders";
> +        } else if (queue.tester) {
> +            categoryName = queue.testCategory;
> +        } else {

Can drop the braces.
Comment 9 Alexey Proskuryakov 2014-08-27 10:14:42 PDT
Committed <http://trac.webkit.org/r173008>.