Bug 136195 - build.webkit.org/dashboard unnecessarily loads results of hidden queues
Summary: build.webkit.org/dashboard unnecessarily loads results of hidden queues
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 136196
  Show dependency treegraph
Reported: 2014-08-23 19:22 PDT by Alexey Proskuryakov
Modified: 2014-08-24 00:10 PDT (History)
3 users (show)

See Also:

proposed fix (5.96 KB, patch)
2014-08-23 19:29 PDT, Alexey Proskuryakov
thorton: review+
Details | Formatted Diff | Diff
patch for landing (6.02 KB, patch)
2014-08-23 23:33 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-08-23 19:22:42 PDT
There is code meant to prevent loading hidden queues, but it's broken.
Comment 1 Alexey Proskuryakov 2014-08-23 19:29:08 PDT
Created attachment 237034 [details]
proposed fix
Comment 2 Tim Horton 2014-08-23 22:44:06 PDT
Comment on attachment 237034 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237034&action=review

> Tools/ChangeLog:13
> +        are triggered by views, so it only makes sens to do the same for initial update.


for *the* initial update?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:35
> +    setTimeout(function() { this._updateHiddenState(); }.bind(this), 0);

Should you do this more like the next line does? Is there a reason for the extra function?
Comment 3 Alexey Proskuryakov 2014-08-23 23:33:34 PDT
Created attachment 237043 [details]
patch for landing
Comment 4 WebKit Commit Bot 2014-08-24 00:10:55 PDT
Comment on attachment 237043 [details]
patch for landing

Clearing flags on attachment: 237043

Committed r172893: <http://trac.webkit.org/changeset/172893>
Comment 5 WebKit Commit Bot 2014-08-24 00:10:58 PDT
All reviewed patches have been landed.  Closing bug.