Bug 136050 – [JSC] Build error on ARM64 with gcc: signed/unsigned comparison error in JSC::GPRInfo::debugName

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Akos Kiss]

When compilig debug version of JSC for arm64 with gcc, the following error is raised:

/home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h: In static member function ‘static const char* JSC::GPRInfo::debugName(JSC::GPRReg)’:
/home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:35:41: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
 #define InvalidGPRReg ((::JSC::GPRReg)-1)
                                         ^
/home/akiss/devel/WebKit/Source/WTF/wtf/Assertions.h:237:8: note: in definition of macro ‘ASSERT’
     (!(assertion) ? \
        ^
/home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:615:46: note: in expansion of macro ‘InvalidGPRReg’
         ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg);
                                              ^

[Akos Kiss]

Created attachment 236788 [details]
Proposed patch.

This change makes the ASSERT in the ARM64 version of GPRInfo::debugName the same as in the other implementations.

[WebKit Commit Bot]

Comment on attachment 236788 [details]
Proposed patch.

Clearing flags on attachment: 236788

Committed r172734: <http://trac.webkit.org/changeset/172734>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.