RESOLVED WONTFIX135500
ARCify MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=135500
Summary ARCify MiniBrowser
Tim Horton
Reported 2014-08-01 02:06:50 PDT
ARC makes Cocoa memory management a good bit simpler. We can't use ARC in WebKit because we need to build 32-bit, but I don't see any reason MiniBrowser would have that requirement (hopefully somebody will chime in if they know why).
Attachments
patch (9.02 KB, patch)
2014-08-01 02:08 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-08-01 02:08:30 PDT
Created attachment 235883 [details] patch
Tim Horton
Comment 2 2014-08-01 02:08:42 PDT
I did this on top of https://bugs.webkit.org/show_bug.cgi?id=135499, so it won't apply.
mitz
Comment 3 2014-08-01 08:26:40 PDT
Seems appropriate to do with the WebKit2 parts of MiniBrowser, since the Modern WebKit API is only available with the modern Objective-C runtime. However, I think we should keep the Legacy WebKit parts working in 32-bit mode, as we have no other means to test it.
Tim Horton
Comment 4 2014-08-01 10:52:09 PDT
That makes sense, and I think mix-and-match memory management is probably not a great idea, so let's not do this! Thanks, Dan!
Sam Weinig
Comment 5 2014-08-02 09:00:52 PDT
Comment on attachment 235883 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235883&action=review > Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:341 > + ARCHS = "$(ARCHS_STANDARD_64_BIT)"; > + CLANG_ENABLE_OBJC_ARC = YES; These should be in the .xcconfig files.
Note You need to log in before you can comment on or make changes to this bug.