Bug 135499 - Make it easer to add switches to MiniBrowser
Summary: Make it easer to add switches to MiniBrowser
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2014-08-01 01:32 PDT by Tim Horton
Modified: 2014-08-01 11:21 PDT (History)
5 users (show)

See Also:

patch (43.65 KB, patch)
2014-08-01 01:52 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-01 01:32:59 PDT
Put all of the settings in one place, share more code between WK{1,2}BrowserWindowController; make them all persistent and as global as they can be.
Comment 1 Tim Horton 2014-08-01 01:52:29 PDT
Created attachment 235882 [details]
Comment 2 WebKit Commit Bot 2014-08-01 01:53:41 PDT
Attachment 235882 [details] did not pass style-queue:

ERROR: Tools/MiniBrowser/mac/SettingsController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 10 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-08-01 11:21:51 PDT