Created attachment 235863 [details]
Comment on attachment 235863 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=235863&action=review
Looks pretty good, though maybe clean
This will actually fail on the first build since file and friend happen during the CMake (configure) phase, but those files won't be available until the build phase. Perhaps we could modify the script to generate the files in the proper place to begin with?
Created attachment 235880 [details]
Part of PlatformWin.cmake is based on https://bugs.webkit.org/show_bug.cgi?id=115944 which I'm trying to update and adapt to all the Windows ports.
I didn't touch InspectorJSBackendDispatchers.cpp, did I? EFL, what's wrong?
Comment on attachment 235880 [details]
Looks fine to me if you can figure out the EFL failure.
Created attachment 235896 [details]
Comment on attachment 235896 [details]
Looks good as long as the bots are happy.
(In reply to comment #9)
This seems to have broken a clean build. Reported here: https://bugs.webkit.org/show_bug.cgi?id=135522