Bug 135484 - more cmake progress
Summary: more cmake progress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Enhancement
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 17:20 PDT by Alex Christensen
Modified: 2014-08-01 15:06 PDT (History)
9 users (show)

See Also:


Attachments
Patch (8.32 KB, patch)
2014-07-31 17:35 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (9.34 KB, patch)
2014-08-01 00:48 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (13.20 KB, patch)
2014-08-01 11:49 PDT, Alex Christensen
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-07-31 17:20:25 PDT
I got WTF to compile and link, JavaScriptCore compiles all the way but doesn't link.  It's reviewing time!
Comment 1 Alex Christensen 2014-07-31 17:35:04 PDT
Created attachment 235863 [details]
Patch
Comment 2 Martin Robinson 2014-07-31 17:47:59 PDT
Comment on attachment 235863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235863&action=review

Looks pretty good, though maybe clean

> Source/JavaScriptCore/CMakeLists.txt:888
> +file(MAKE_DIRECTORY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector)
> +file(COPY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSBackendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSFrontendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSTypeBuilders.h DESTINATION ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector)

This will actually fail on the first build since file and friend happen during the CMake (configure) phase, but those files won't be available until the build phase. Perhaps we could modify the script to generate the files in the proper place to begin with?
Comment 3 Alex Christensen 2014-08-01 00:48:54 PDT
Created attachment 235880 [details]
Patch
Comment 4 Alex Christensen 2014-08-01 00:50:28 PDT
Part of PlatformWin.cmake is based on https://bugs.webkit.org/show_bug.cgi?id=115944 which I'm trying to update and adapt to all the Windows ports.
Comment 5 Alex Christensen 2014-08-01 10:17:31 PDT
I didn't touch InspectorJSBackendDispatchers.cpp, did I?  EFL, what's wrong?
Comment 6 Martin Robinson 2014-08-01 11:25:40 PDT
Comment on attachment 235880 [details]
Patch

Looks fine to me if you can figure out the EFL failure.
Comment 7 Alex Christensen 2014-08-01 11:49:11 PDT
Created attachment 235896 [details]
Patch
Comment 8 Martin Robinson 2014-08-01 11:51:19 PDT
Comment on attachment 235896 [details]
Patch

Looks good as long as the bots are happy.
Comment 9 Alex Christensen 2014-08-01 12:19:47 PDT
http://trac.webkit.org/changeset/171942
Comment 10 Carlos Alberto Lopez Perez 2014-08-01 15:06:18 PDT
(In reply to comment #9)
> http://trac.webkit.org/changeset/171942

This seems to have broken a clean build. Reported here: https://bugs.webkit.org/show_bug.cgi?id=135522