RESOLVED FIXED 135484
more cmake progress 
https://bugs.webkit.org/show_bug.cgi?id=135484
Summary more cmake progress
Alex Christensen
Reported 2014-07-31 17:20:25 PDT
I got WTF to compile and link, JavaScriptCore compiles all the way but doesn't link. It's reviewing time!
Attachments
Patch (8.32 KB, patch)
2014-07-31 17:35 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.34 KB, patch)
2014-08-01 00:48 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (13.20 KB, patch)
2014-08-01 11:49 PDT, Alex Christensen 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-07-31 17:35:04 PDT
Created attachment 235863 [details] Patch
Martin Robinson
Comment 2 2014-07-31 17:47:59 PDT
Comment on attachment 235863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235863&action=review Looks pretty good, though maybe clean > Source/JavaScriptCore/CMakeLists.txt:888 > +file(MAKE_DIRECTORY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector) > +file(COPY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSBackendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSFrontendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSTypeBuilders.h DESTINATION ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector) This will actually fail on the first build since file and friend happen during the CMake (configure) phase, but those files won't be available until the build phase. Perhaps we could modify the script to generate the files in the proper place to begin with?
Alex Christensen
Comment 3 2014-08-01 00:48:54 PDT
Created attachment 235880 [details] Patch
Alex Christensen
Comment 4 2014-08-01 00:50:28 PDT
Part of PlatformWin.cmake is based on https://bugs.webkit.org/show_bug.cgi?id=115944 which I'm trying to update and adapt to all the Windows ports.
Alex Christensen
Comment 5 2014-08-01 10:17:31 PDT
I didn't touch InspectorJSBackendDispatchers.cpp, did I? EFL, what's wrong?
Martin Robinson
Comment 6 2014-08-01 11:25:40 PDT
Comment on attachment 235880 [details] Patch Looks fine to me if you can figure out the EFL failure.
Alex Christensen
Comment 7 2014-08-01 11:49:11 PDT
Created attachment 235896 [details] Patch
Martin Robinson
Comment 8 2014-08-01 11:51:19 PDT
Comment on attachment 235896 [details] Patch Looks good as long as the bots are happy.
Alex Christensen
Comment 9 2014-08-01 12:19:47 PDT
http://trac.webkit.org/changeset/171942
Carlos Alberto Lopez Perez
Comment 10 2014-08-01 15:06:18 PDT
(In reply to comment #9) > http://trac.webkit.org/changeset/171942 This seems to have broken a clean build. Reported here: https://bugs.webkit.org/show_bug.cgi?id=135522
Note You need to log in before you can comment on or make changes to this bug.