Bug 135522 – REGRESSION(r171942): [CMAKE] build broken (clean build)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

r171942 <http://trac.webkit.org/r171942> broke the build.

The bots are green because it only breaks if you do a clean build (It don't seems to break if you rebuild from a previous revision)

Test with:

# Clean the build
rm -fr WebKitBuild/Release/

# Build webkit
Tools/Scripts/build-webkit --no-webkit1 --release --gtk

In file included from DerivedSources/WebCore/InspectorWebBackendDispatchers.h:12:0,
                 from ../../Source/WebCore/inspector/InspectorDOMAgent.h:36,
                 from ../../Source/WebCore/bindings/js/JSCommandLineAPIHostCustom.cpp:40:
DerivedSources/WebCore/InspectorWebTypeBuilders.h:14:47: fatal error: inspector/InspectorJSTypeBuilders.h: No such file or directory
 #include <inspector/InspectorJSTypeBuilders.h>
                                               ^
compilation terminated.
ninja: build stopped: subcommand failed.

[Alex Christensen]

Sorry about the breakage.  It's related to this change:
-    COMMAND ${PYTHON_EXECUTABLE} ${JavaScriptCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" --output_cpp_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" --output_js_dir "${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol" --output_type JavaScript --write_always && mkdir -p ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector && cp ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSBackendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSFrontendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSTypeBuilders.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector
+    COMMAND ${PYTHON_EXECUTABLE} ${JavaScriptCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" --output_cpp_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector" --output_js_dir "${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol" --output_type JavaScript --write_always
     VERBATIM)
+file(MAKE_DIRECTORY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector)

I'm not sure if we want to revert it to keep the bots green or find a better fix, but I have no access to a machine actually building GTK or EFL, and we need to get rid of the cp command sometime soon anyway.

Is there a good fix for this?

[Carlos Alberto Lopez Perez]

(In reply to comment #1)
> 
> I'm not sure if we want to revert it to keep the bots green or find a better fix, but I have no access to a machine actually building GTK or EFL, and we need to get rid of the cp command sometime soon anyway.
> 
> Is there a good fix for this?

I think I have a patch. I will upload it soon for review.

[Carlos Alberto Lopez Perez]

Created attachment 235923 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 235923 [details]
Patch

Clearing flags on attachment: 235923

Committed r171961: <http://trac.webkit.org/changeset/171961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.