On Fedora I need mesa-libGLES-devel installed in order to build WebKitGTK+, but it's not listed in Tools/gtk/install-dependencies. I'll add it to the list of Debian dependencies as well (which I did not test, but I'm pretty sure I have the right package).
Created attachment 235521 [details] Patch
How is the build failing?
*** Bug 135238 has been marked as a duplicate of this bug. ***
(In reply to comment #3) > *** Bug 135238 has been marked as a duplicate of this bug. *** Feel free to land this one.
(In reply to comment #2) > How is the build failing? If I remember correctly it's failing in Extensions3DOpenGLES.cpp.
In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:30:0: ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:32:23: fatal error: GLES2/gl2.h: No such file or directory #include <GLES2/gl2.h> ^ compilation terminated.
(In reply to comment #6) > In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:30:0: > ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:32:23: fatal error: GLES2/gl2.h: No such file or directory > #include <GLES2/gl2.h> > ^ > compilation terminated. Hrm. Odd. This should only be compiled if OpenGLES support is installed.
Created attachment 235675 [details] Patch I think those are unconditionally build so I guess we need to add the proper guards
Comment on attachment 235675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235675&action=review > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:275 > +#if USE(EGL) Why use(EGL) here? The context creation API shouldn't come into play here, as far as I can tell.
Comment on attachment 235675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235675&action=review >> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:275 >> +#if USE(EGL) > > Why use(EGL) here? The context creation API shouldn't come into play here, as far as I can tell. Sure, this change is not directly related to the failure, I just saw the egl include on top and decided to improve a bit the guarding of the file, but I can remove it.
Comment on attachment 235675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235675&action=review >>> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:275 >>> +#if USE(EGL) >> >> Why use(EGL) here? The context creation API shouldn't come into play here, as far as I can tell. > > Sure, this change is not directly related to the failure, I just saw the egl include on top and decided to improve a bit the guarding of the file, but I can remove it. Ah, I see now! I think it's okay to simply fail to build when you try to use OpenGLES without EGL. There aren't any platforms that support this configuration that I know of.
Created attachment 235745 [details] Patch
Comment on attachment 235745 [details] Patch Clearing flags on attachment: 235745 Committed r171799: <http://trac.webkit.org/changeset/171799>
All reviewed patches have been landed. Closing bug.