RESOLVED FIXED 135207
Web Inspector: InspectorBackend's promise-based agent API does not support multiple return values 
https://bugs.webkit.org/show_bug.cgi?id=135207
Summary Web Inspector: InspectorBackend's promise-based agent API does not support mu...
Brian Burg
Reported 2014-07-23 12:16:15 PDT
The existing implementation (InspectorBackend.Command.prototype.promise) assumes that there is only one return value (as a payload object, hence variable name 'payload') but InspectorBackend will actually unpack multiple return values as multiple callback arguments. The wrapper callback here should instead slice the arguments array (excluding the error message) and apply that to the resolve thunk.
Attachments
Patch (1.95 KB, patch)
2014-07-23 12:21 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
Patch (7.12 KB, patch)
2014-07-23 13:33 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-23 12:16:47 PDT
<rdar://problem/17782742>
Brian Burg
Comment 2 2014-07-23 12:21:27 PDT
Created attachment 235367 [details] Patch
Brian Burg
Comment 3 2014-07-23 13:33:52 PDT
Created attachment 235371 [details] Patch
Joseph Pecoraro
Comment 4 2014-07-23 13:44:38 PDT
Comment on attachment 235371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235371&action=review Clever. Sounds good for now! r=me > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:377 > + // than by setting a magical property on the callback. <webkit.org/b/132386> Nit: Include "https://" on that URL.
WebKit Commit Bot
Comment 5 2014-07-23 14:16:53 PDT
Comment on attachment 235371 [details] Patch Clearing flags on attachment: 235371 Committed r171489: <http://trac.webkit.org/changeset/171489>
WebKit Commit Bot
Comment 6 2014-07-23 14:16:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.