Bug 132386 - Web Inspector: differentiate callback argument conventions by invoking commands differently
Summary: Web Inspector: differentiate callback argument conventions by invoking comman...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-30 10:12 PDT by Brian Burg
Modified: 2017-04-06 15:47 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-30 10:12:33 PDT 
Right now there's one place where the code sets a magical .expectsResultObject on the callback passed to a backend command invocation.

I think we should disambiguate this by adding a different method (like .invoke or .promise) rather than using a magic property.
Comment 1 Radar WebKit Bug Importer 2014-04-30 10:13:10 PDT 
<rdar://problem/16770631>
Comment 2 BJ Burg 2017-04-06 15:47:47 PDT 
This is nowadays auto-detected based on the type of the last argument. Closing.