135019 – [ftlopt] DFG Flush(SetLocal) store elimination is overzealous for captured variables in the presence of nodes that have no effects but may throw (merge trunk r171190)

RESOLVED FIXED 135019

[ftlopt] DFG Flush(SetLocal) store elimination is overzealous for captured variables in the presence of nodes that have no effects but may throw (merge trunk r171190)

https://bugs.webkit.org/show_bug.cgi?id=135019

Summary [ftlopt] DFG Flush(SetLocal) store elimination is overzealous for captured va...

Filip Pizlo

Reported 2014-07-17 12:28:13 PDT

This is about merging https://bugs.webkit.org/show_bug.cgi?id=134988. The merge requires some finesse so I'd rather get another review.

Attachments
the patch (6.24 KB, patch) 2014-07-17 12:31 PDT, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2014-07-17 12:31:15 PDT

Created attachment 235084 [details] the patch

Filip Pizlo

Comment 2 2014-07-17 22:56:20 PDT

Landed in http://trac.webkit.org/changeset/171214

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component JavaScriptCore

Assignee

Filip Pizlo

Reported

2014-07-17 12:28 PDT

Modified

2014-07-17 22:56 PDT History

CC List

7 users Show

URL

Keywords

Depends on

134988

Blocks

Dependencies

tree graph