RESOLVED FIXED 134988
DFG Flush(SetLocal) store elimination is overzealous for captured variables in the presence of nodes that have no effects but may throw 
https://bugs.webkit.org/show_bug.cgi?id=134988
Summary DFG Flush(SetLocal) store elimination is overzealous for captured variables i...
Filip Pizlo
Reported 2014-07-16 12:09:31 PDT
Patch forthcoming.
Attachments
the patch (7.32 KB, patch)
2014-07-16 12:19 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (648.62 KB, application/zip)
2014-07-16 14:32 PDT, Build Bot 		no flags
Details
the patch (11.57 KB, patch)
2014-07-16 20:00 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-07-16 12:19:21 PDT
Created attachment 235014 [details] the patch
Mark Hahnenberg
Comment 2 2014-07-16 12:27:21 PDT
Comment on attachment 235014 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=235014&action=review r=me > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:970 > // Be safe in release mode. This comment doesn't make sense any more.
Build Bot
Comment 3 2014-07-16 14:32:39 PDT
Comment on attachment 235014 [details] the patch Attachment 235014 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4745035249614848 New failing tests: media/media-fragments/TC0001.html
Build Bot
Comment 4 2014-07-16 14:32:42 PDT
Created attachment 235022 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Filip Pizlo
Comment 5 2014-07-16 20:00:03 PDT
Created attachment 235045 [details] the patch
Radar WebKit Bug Importer
Comment 6 2014-07-16 20:08:38 PDT
<rdar://problem/17706349>
Filip Pizlo
Comment 7 2014-07-17 11:18:23 PDT
Landed in http://trac.webkit.org/changeset/171190
Note You need to log in before you can comment on or make changes to this bug.