Fix simple warning caused by unused parameter.
Created attachment 234997 [details] Patch
Comment on attachment 234997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234997&action=review > Source/WebKit2/ChangeLog:3 > + Fix warning. Title really doesn't contain any information.
Created attachment 235065 [details] Patch Apply reviewer's comment.
Comment on attachment 235065 [details] Patch LGTM
Comment on attachment 235065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222 > +void EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent(void*, Evas*, Evas_Object*, void*) > { > Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data); How can this possibly compile? The data argument is used!
(In reply to comment #5) > (From update of attachment 235065 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review > > > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222 > > +void EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent(void*, Evas*, Evas_Object*, void*) > > { > > Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data); > > How can this possibly compile? The data argument is used! You are right, last patch was written on the old snapshot. :( Thank you for you correction. I will update the patch soon.
Created attachment 235102 [details] Patch rebase the patch.
Comment on attachment 235065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222 >>> Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data); >> >> How can this possibly compile? The data argument is used! > > You are right, last patch was written on the old snapshot. :( > Thank you for you correction. > I will update the patch soon. Oops. I'm sorry. I missed it. But, it is weird because efl-wk2 ews was fine. :( Let me check if efl ews is working correctly.
(In reply to comment #9) > (From update of attachment 235065 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review > > >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222 > >>> Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data); > >> > >> How can this possibly compile? The data argument is used! > > > > You are right, last patch was written on the old snapshot. :( > > Thank you for you correction. > > I will update the patch soon. > > Oops. I'm sorry. I missed it. But, it is weird because efl-wk2 ews was fine. :( Let me check if efl ews is working correctly. efl-ews tested this patch based on latest code. Latest code doesn't use the argument. That's why efl-ews didn't detect build break !
Comment on attachment 235102 [details] Patch r+ed again. And I will take care of reviewing further. Thanks Darin !
Comment on attachment 235102 [details] Patch Clearing flags on attachment: 235102 Committed r171291: <http://trac.webkit.org/changeset/171291>
All reviewed patches have been landed. Closing bug.
*** Bug 134719 has been marked as a duplicate of this bug. ***