Bug 134975 - Fix warnings caused by unused parameter
Summary: Fix warnings caused by unused parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 134719 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-16 08:36 PDT by KwangHyuk
Modified: 2014-09-15 01:37 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2014-07-16 08:39 PDT, KwangHyuk
gyuyoung.kim: review-
Details | Formatted Diff | Diff
Patch (2.09 KB, patch)
2014-07-17 05:36 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2014-07-17 17:54 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2014-07-16 08:36:48 PDT
Fix simple warning caused by unused parameter.
Comment 1 KwangHyuk 2014-07-16 08:39:44 PDT
Created attachment 234997 [details]
Patch
Comment 2 Gyuyoung Kim 2014-07-16 17:48:20 PDT
Comment on attachment 234997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234997&action=review

> Source/WebKit2/ChangeLog:3
> +        Fix warning.

Title really doesn't contain any information.
Comment 3 KwangHyuk 2014-07-17 05:36:06 PDT
Created attachment 235065 [details]
Patch

Apply reviewer's comment.
Comment 4 Gyuyoung Kim 2014-07-17 07:16:38 PDT
Comment on attachment 235065 [details]
Patch

LGTM
Comment 5 Darin Adler 2014-07-17 09:28:03 PDT
Comment on attachment 235065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222
> +void EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent(void*, Evas*, Evas_Object*, void*)
>  {
>      Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data);

How can this possibly compile? The data argument is used!
Comment 6 KwangHyuk 2014-07-17 17:44:18 PDT
(In reply to comment #5)
> (From update of attachment 235065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222
> > +void EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent(void*, Evas*, Evas_Object*, void*)
> >  {
> >      Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data);
> 
> How can this possibly compile? The data argument is used!

You are right, last patch was written on the old snapshot. :(
Thank you for you correction.
I will update the patch soon.
Comment 7 KwangHyuk 2014-07-17 17:54:06 PDT
Created attachment 235102 [details]
Patch

rebase the patch.
Comment 8 Gyuyoung Kim 2014-07-17 18:59:29 PDT
Comment on attachment 235065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review

>>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222
>>>      Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data);
>> 
>> How can this possibly compile? The data argument is used!
> 
> You are right, last patch was written on the old snapshot. :(
> Thank you for you correction.
> I will update the patch soon.

Oops. I'm sorry. I missed it. But, it is weird because efl-wk2 ews was fine. :( Let me check if efl ews is working correctly.
Comment 9 Gyuyoung Kim 2014-07-17 18:59:30 PDT
Comment on attachment 235065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review

>>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222
>>>      Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data);
>> 
>> How can this possibly compile? The data argument is used!
> 
> You are right, last patch was written on the old snapshot. :(
> Thank you for you correction.
> I will update the patch soon.

Oops. I'm sorry. I missed it. But, it is weird because efl-wk2 ews was fine. :( Let me check if efl ews is working correctly.
Comment 10 Gyuyoung Kim 2014-07-17 19:19:01 PDT
(In reply to comment #9)
> (From update of attachment 235065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235065&action=review
> 
> >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:222
> >>>      Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data);
> >> 
> >> How can this possibly compile? The data argument is used!
> > 
> > You are right, last patch was written on the old snapshot. :(
> > Thank you for you correction.
> > I will update the patch soon.
> 
> Oops. I'm sorry. I missed it. But, it is weird because efl-wk2 ews was fine. :( Let me check if efl ews is working correctly.

efl-ews tested this patch based on latest code. Latest code doesn't use the argument. That's why efl-ews didn't detect build break !
Comment 11 Gyuyoung Kim 2014-07-17 19:20:49 PDT
Comment on attachment 235102 [details]
Patch

r+ed again. And I will take care of reviewing further. Thanks Darin !
Comment 12 WebKit Commit Bot 2014-07-20 22:37:21 PDT
Comment on attachment 235102 [details]
Patch

Clearing flags on attachment: 235102

Committed r171291: <http://trac.webkit.org/changeset/171291>
Comment 13 WebKit Commit Bot 2014-07-20 22:37:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Tanay 2014-09-15 01:37:58 PDT
*** Bug 134719 has been marked as a duplicate of this bug. ***