Bug 134958 - Adding myself to contributors.json breaks a webkitpy test
Summary: Adding myself to contributors.json breaks a webkitpy test
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-07-15 18:55 PDT by Carlos Alberto Lopez Perez
Modified: 2014-07-15 21:31 PDT (History)
9 users (show)

See Also:

Patch (2.10 KB, patch)
2014-07-15 19:06 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-07-15 18:55:02 PDT
I was adding myself to Tools/Scripts/webkitpy/common/config/contributors.json after I was accepted as commiter.

However, doing it breaks a test of webkitpy due to usage of the very common spanish surname "lopez" as whois query for the IRC bot tests.

$ Tools/Scripts/test-webkitpy
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

Checking imports .../home/clopez/webkit/webkit
[809/1424] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_whois failed:                                                             
  Traceback (most recent call last):
    File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py", line 56, in test_whois
      whois.execute("tom", ["lopez"], None, None))
  AssertionError: 'tom: lopez is "Xan Lopez" <xan.lopez@gmail.com> (:xan) (r). Why do you ask?' != u'tom: I\'m not sure who you mean?  "Carlos Alberto Lopez Perez" <clopez@igalia.com> (:clopez) (c) or "Xan Lopez" <xan.lopez@gmail.com> (:xan) (r) could be \'lopez\'.'
Ran 1424 tests in 3.843s                                                                              
FAILED (failures=1, errors=0)
Comment 1 Carlos Alberto Lopez Perez 2014-07-15 19:06:08 PDT
Created attachment 234972 [details]
Comment 2 WebKit Commit Bot 2014-07-15 21:31:43 PDT
Comment on attachment 234972 [details]

Clearing flags on attachment: 234972

Committed r171136: <http://trac.webkit.org/changeset/171136>
Comment 3 WebKit Commit Bot 2014-07-15 21:31:47 PDT
All reviewed patches have been landed.  Closing bug.