RESOLVED INVALID 134957
Adding myself to contributors.json breaks a webkitpy test.
https://bugs.webkit.org/show_bug.cgi?id=134957
Summary Adding myself to contributors.json breaks a webkitpy test.
Carlos Alberto Lopez Perez
Reported 2014-07-15 18:52:48 PDT
I was adding myself to Tools/Scripts/webkitpy/common/config/contributors.json after I was accepted as commiter. However, doing it breaks a test of webkitpy: $ Tools/Scripts/test-webkitpy Suppressing most webkitpy logging while running unit tests. Skipping tests in the following modules or packages because they are really, really, slow: webkitpy.common.checkout.scm.scm_unittest (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include) Checking imports .../home/clopez/webkit/webkit [809/1424] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_whois failed: Traceback (most recent call last): File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py", line 56, in test_whois whois.execute("tom", ["lopez"], None, None)) AssertionError: 'tom: lopez is "Xan Lopez" <xan.lopez@gmail.com> (:xan) (r). Why do you ask?' != u'tom: I\'m not sure who you mean? "Carlos Alberto Lopez Perez" <clopez@igalia.com> (:clopez) (c) or "Xan Lopez" <xan.lopez@gmail.com> (:xan) (r) could be \'lopez\'.' Ran 1424 tests in 3.843s FAILED (failures=1, errors=0)
Attachments
Note You need to log in before you can comment on or make changes to this bug.