Bug 134793 - media/W3C/video/readyState/readyState_during_canplay.html often flakey
Summary: media/W3C/video/readyState/readyState_during_canplay.html often flakey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ahmad Saleem
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-09 19:10 PDT by Simon Fraser (smfr)
Modified: 2023-10-28 14:43 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-07-09 19:10:00 PDT
Often in EWS:
New failing tests:
media/W3C/video/readyState/readyState_during_canplay.html

e.g. in bug 134789.
Comment 1 Alexey Proskuryakov 2014-07-12 01:03:58 PDT
See also bug 122475. I think that this is a misplaced failure due to another test timing out.
Comment 2 Ahmad Saleem 2023-10-25 13:39:45 PDT
We can delete this local copy of test in favor of WPT:

https://wpt.fyi/results/html/semantics/embedded-content/media-elements/readyState_during_canplay.html?label=experimental&label=master&aligned=

and update this expectation:

https://searchfox.org/wubkat/source/LayoutTests/platform/mac-wk2/TestExpectations#1014


[ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplay.html [ Pass Failure ]

____

Can do PR with following:

1) Delete local copy of test
2) Import single new copy of above test from WPT
3) Remove above 'Test Expectation
4) Run through EWS to see if it works across all platforms
5) If all good then enable it and if not, then raise platform specific bugs and track in newer bug

___

Any input / suggestions?
Comment 3 Eric Carlson 2023-10-27 08:59:49 PDT
(In reply to Ahmad Saleem from comment #2)
> We can delete this local copy of test in favor of WPT:
> 
> https://wpt.fyi/results/html/semantics/embedded-content/media-elements/
> readyState_during_canplay.html?label=experimental&label=master&aligned=
> 
> and update this expectation:
> 
> https://searchfox.org/wubkat/source/LayoutTests/platform/mac-wk2/
> TestExpectations#1014
> 
> 
> [ Release ]
> imported/w3c/web-platform-tests/html/semantics/embedded-content/media-
> elements/readyState_during_canplay.html [ Pass Failure ]
> 
> ____
> 
> Can do PR with following:
> 
> 1) Delete local copy of test
> 2) Import single new copy of above test from WPT
> 3) Remove above 'Test Expectation
> 4) Run through EWS to see if it works across all platforms
> 5) If all good then enable it and if not, then raise platform specific bugs
> and track in newer bug
> 
> ___
> 
> Any input / suggestions?

Good plan, thank you!
Comment 4 Ahmad Saleem 2023-10-27 15:44:31 PDT
Copy in our tree is latest from WPT, so just removing old test case and expectation: https://github.com/WebKit/WebKit/pull/19659
Comment 5 EWS 2023-10-28 14:42:20 PDT
Committed 269894@main (ed96df022f4f): <https://commits.webkit.org/269894@main>

Reviewed commits have been landed. Closing PR #19659 and removing active labels.
Comment 6 Radar WebKit Bug Importer 2023-10-28 14:43:13 PDT
<rdar://problem/117633522>