Bug 122475 - A test that hangs at cleanup stage confuses webkitpy hugely
Summary: A test that hangs at cleanup stage confuses webkitpy hugely
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2013-10-07 17:29 PDT by Alexey Proskuryakov
Modified: 2016-08-23 09:39 PDT (History)
4 users (show)

See Also:

freeze (dont open!) (68 bytes, text/html)
2014-06-05 13:33 PDT, Alexey Proskuryakov
no flags Details
proposed fix (4.70 KB, patch)
2014-07-16 16:26 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-07 17:29:08 PDT
fast/forms/form-associated-element-crash3.html is a test that's known to hang after it dumps results (see bug 122130). Having a test like this confuses WebKitTestRunner a lot.

1. There is output saying that last line of output was not a newline, and there is a bug.
2. The next test is incorrectly reported as crashing.

$ run-webkit-tests -2 --no-retry-failures -v fast/forms --child-processes=1
[150/810] fast/forms/form-associated-element-crash3.html passed
Last character read from DRT stdout line was not a newline!  This indicates either a NRWT or DRT bug.
[151/810] fast/forms/form-associated-element-removal.html failed (WebProcess crashed [pid=44775])
Comment 1 Dirk Pranke 2013-10-07 18:23:13 PDT
This is probably essentially the same as bug 118602. It's not clear that there's a good way to fix this given the current way the test harness communicates w/ WTR.
Comment 2 Alexey Proskuryakov 2014-06-05 13:33:21 PDT
Created attachment 232579 [details]
freeze (dont open!)

Updated steps to reproduce:
1. Download attached freeze.html into LayoutTests.
2. run-webkit-tests -2 freeze.html fast/encoding/ahram-org-eg.html --debug-rwt-logging --child-processes=1
Comment 3 Alexey Proskuryakov 2014-06-05 13:52:11 PDT
Comment 4 Alexey Proskuryakov 2014-07-16 16:26:55 PDT
Created attachment 235034 [details]
proposed fix
Comment 5 Simon Fraser (smfr) 2014-07-16 16:49:32 PDT
Comment on attachment 235034 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=235034&action=review

> Tools/WebKitTestRunner/TestInvocation.cpp:206
> +        // The process froze while loading about:blank, let's start a fresh one.
> +        // It would be nice to report that the previous test froze after dumping results, but we have no way to do that.

Can we log here?
Comment 6 Alexey Proskuryakov 2014-07-16 16:54:49 PDT
No, the script doesn't expect any output before the next test begins.
Comment 7 WebKit Commit Bot 2014-07-16 19:27:02 PDT
Comment on attachment 235034 [details]
proposed fix

Clearing flags on attachment: 235034

Committed r171167: <http://trac.webkit.org/changeset/171167>
Comment 8 WebKit Commit Bot 2014-07-16 19:27:05 PDT
All reviewed patches have been landed.  Closing bug.