Bug 134246 – REGRESSION(r170235): Remove incorrect ifdef guard

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Éva Balázsfalvi]

Removr unnecessary #if guard which remained in the code while removing PAGE_VISIBILITY_API compile guard.

> Source/WebKit/mac/WebView/WebView.mm:4328
> #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
>      if (_private->page)
>          return kit(_private->page->visibilityState());
>  #endif

[Éva Balázsfalvi]

Created attachment 233692 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #1)
> Created an attachment (id=233692) [details]
> Patch

https://bugs.webkit.org/show_bug.cgi?id=133844#c4
> -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)

I agree, this guard is really unnecessary, "true || FOO" is always true.

[Csaba Osztrogonác]

Comment on attachment 233692 [details]
Patch

LGTM, r=me. Thanks for the quick fix.

[WebKit Commit Bot]

Comment on attachment 233692 [details]
Patch

Clearing flags on attachment: 233692

Committed r170358: <http://trac.webkit.org/changeset/170358>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Enrica Casucci]

This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING.
You removed the #ifdef but you left it around the kit function on line 521.

[Csaba Osztrogonác]

(In reply to comment #6)
> This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING.
> You removed the #ifdef but you left it around the kit function on line 521.

In this case the original guarding was incorrect. This call was guarded with
"#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)".
But now there isn't PAGE_VISIBILITY_API guard, so we need this kit call
unconditionally. Should we remove guards around kit function core?

[Csaba Osztrogonác]

Thanks for the fix landed in https://trac.webkit.org/changeset/170372 .