Bug 133844 – Removing PAGE_VISIBILITY_API compile guard

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Éva Balázsfalvi]

https://lists.webkit.org/pipermail/webkit-dev/2014-January/026105.html
"This feature is now stable & I think this is enabled on all ports, I plan to remove the #ifdefs."

I checked, it is enabled everywhere: EFL, GTK, Mac (iOS too), Windows

[Éva Balázsfalvi]

Created attachment 233044 [details]
Patch

[Csaba Osztrogonác]

Landed in https://trac.webkit.org/changeset/170235

[Andreas Kling]

Comment on attachment 233044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233044&action=review

> Source/WebKit/mac/WebView/WebView.mm:4327
> -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
>      if (_private->page)
>          return kit(_private->page->visibilityState());
>  #endif

This looks wrong, now the code will only run if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) is true.
Shouldn't we remove the #if guard entirely here?

[Éva Balázsfalvi]

(In reply to comment #3)
> (From update of attachment 233044 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233044&action=review
> 
> > Source/WebKit/mac/WebView/WebView.mm:4327
> > -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> > +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> >      if (_private->page)
> >          return kit(_private->page->visibilityState());
> >  #endif
> 
> This looks wrong, now the code will only run if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) is true.
> Shouldn't we remove the #if guard entirely here?

Good point, thanks for noticing,

Sorry, my bad. I've made a quick fix: https://bugs.webkit.org/show_bug.cgi?id=134246