Bug 134108 – Gamepad API - "Deprecate" the existing implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Gamepad API - "Deprecate" the existing implementation

To cause less pain while implementing the new Gamepad API (https://bugs.webkit.org/show_bug.cgi?id=134076) the old version should be left in the tree deprecated.

This will include renaming "GAMEPAD" to "GAMEPAD_DEPRECATED", as well as appending the "Deprecated" prefix to the files in the tree that will conflict with the new implementation.

[Brady Eidson]

Created attachment 233438 [details]
Patch v1

[Brady Eidson]

Because of the EFL build-breakage list, I'll wait for EWS on this one before commit-queueing it

[Brady Eidson]

Build was broken without the patch, so I'll land it.

[Brady Eidson]

Created attachment 233463 [details]
Patch for landing

Commit queue was busted because of turbulence in the tree - trying again.

[WebKit Commit Bot]

Comment on attachment 233463 [details]
Patch for landing

Rejecting attachment 233463 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 233463, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Tim Hatcher found in /Volumes/Data/EWS/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6346875045150720

[Brady Eidson]

Created attachment 233501 [details]
Patch for landing with Timothy's full name (thanks, automation!)

[Brady Eidson]

Okay one more CQ try now that we suspect it should be unwedged.

[Brady Eidson]

Created attachment 233533 [details]
Patch for landing v172

[WebKit Commit Bot]

Comment on attachment 233533 [details]
Patch for landing v172

Clearing flags on attachment: 233533

Committed r170244: <http://trac.webkit.org/changeset/170244>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 134157

[Brady Eidson]

Created attachment 233537 [details]
New approach - v1

Instead of suffix'ing the old files with "Deprecated", just move them as-is into a "deprecated" subdirectory

This is for an EWS run

[WebKit Commit Bot]

Attachment 233537 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/gamepad/deprecated/GamepadList.h:50:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

EFL down, GTK to go.

[Brady Eidson]

The GTK build breakage is not due to this patch.  Landing it!

[WebKit Commit Bot]

Comment on attachment 233537 [details]
New approach - v1

Clearing flags on attachment: 233537

Committed r170249: <http://trac.webkit.org/changeset/170249>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.