Bug 134108 - Gamepad API - "Deprecate" the existing implementation
Summary: Gamepad API - "Deprecate" the existing implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 134157
Blocks: 134076
  Show dependency treegraph
 
Reported: 2014-06-20 10:08 PDT by Brady Eidson
Modified: 2014-06-21 12:07 PDT (History)
11 users (show)

See Also:


Attachments
Patch v1 (67.73 KB, patch)
2014-06-20 11:43 PDT, Brady Eidson
timothy: review+
beidson: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (67.71 KB, patch)
2014-06-20 15:06 PDT, Brady Eidson
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing with Timothy's full name (thanks, automation!) (67.74 KB, patch)
2014-06-20 20:04 PDT, Brady Eidson
beidson: commit-queue-
Details | Formatted Diff | Diff
Patch for landing v172 (67.58 KB, patch)
2014-06-21 07:56 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
New approach - v1 (79.33 KB, patch)
2014-06-21 10:04 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-06-20 10:08:56 PDT
Gamepad API - "Deprecate" the existing implementation

To cause less pain while implementing the new Gamepad API (https://bugs.webkit.org/show_bug.cgi?id=134076) the old version should be left in the tree deprecated.

This will include renaming "GAMEPAD" to "GAMEPAD_DEPRECATED", as well as appending the "Deprecated" prefix to the files in the tree that will conflict with the new implementation.
Comment 1 Brady Eidson 2014-06-20 11:43:53 PDT
Created attachment 233438 [details]
Patch v1
Comment 2 Brady Eidson 2014-06-20 11:47:11 PDT
Because of the EFL build-breakage list, I'll wait for EWS on this one before commit-queueing it
Comment 3 Brady Eidson 2014-06-20 14:11:33 PDT
Build was broken without the patch, so I'll land it.
Comment 4 Brady Eidson 2014-06-20 15:06:49 PDT
Created attachment 233463 [details]
Patch for landing

Commit queue was busted because of turbulence in the tree - trying again.
Comment 5 WebKit Commit Bot 2014-06-20 19:17:50 PDT
Comment on attachment 233463 [details]
Patch for landing

Rejecting attachment 233463 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 233463, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Tim Hatcher found in /Volumes/Data/EWS/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6346875045150720
Comment 6 Brady Eidson 2014-06-20 20:04:02 PDT
Created attachment 233501 [details]
Patch for landing with Timothy's full name (thanks, automation!)
Comment 7 Brady Eidson 2014-06-21 07:49:56 PDT
Okay one more CQ try now that we suspect it should be unwedged.
Comment 8 Brady Eidson 2014-06-21 07:56:04 PDT
Created attachment 233533 [details]
Patch for landing v172
Comment 9 WebKit Commit Bot 2014-06-21 08:44:15 PDT
Comment on attachment 233533 [details]
Patch for landing v172

Clearing flags on attachment: 233533

Committed r170244: <http://trac.webkit.org/changeset/170244>
Comment 10 WebKit Commit Bot 2014-06-21 08:44:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Commit Bot 2014-06-21 09:21:02 PDT
Re-opened since this is blocked by bug 134157
Comment 12 Brady Eidson 2014-06-21 10:04:55 PDT
Created attachment 233537 [details]
New approach - v1

Instead of suffix'ing the old files with "Deprecated", just move them as-is into a "deprecated" subdirectory

This is for an EWS run
Comment 13 WebKit Commit Bot 2014-06-21 10:07:09 PDT
Attachment 233537 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/gamepad/deprecated/GamepadList.h:50:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Brady Eidson 2014-06-21 10:27:21 PDT
EFL down, GTK to go.
Comment 15 Brady Eidson 2014-06-21 11:36:14 PDT
The GTK build breakage is not due to this patch.  Landing it!
Comment 16 WebKit Commit Bot 2014-06-21 12:07:34 PDT
Comment on attachment 233537 [details]
New approach - v1

Clearing flags on attachment: 233537

Committed r170249: <http://trac.webkit.org/changeset/170249>
Comment 17 WebKit Commit Bot 2014-06-21 12:07:41 PDT
All reviewed patches have been landed.  Closing bug.