Bug 134106 – [Win] Menu list theme is not drawn.

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebCore Misc.

Dropdown menus are not rendered on Windows.
A virtual drawing method has changed signature, and the override on Windows needs updating.

Created attachment 233429 [details]
Patch

[Alex Christensen]

Comment on attachment 233429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review

> Source/WebCore/rendering/RenderThemeWin.cpp:803
> +    adjustMenuListButtonStyle(*styleResolver, *style, *e);

I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.

(In reply to comment #2)
> (From update of attachment 233429 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review
> 

Thanks for looking into this :)

> > Source/WebCore/rendering/RenderThemeWin.cpp:803
> > +    adjustMenuListButtonStyle(*styleResolver, *style, *e);
> 
> I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.

I agree, could we perhaps address this in a separate patch, since it's a bigger change, involving all platforms?

[Alex Christensen]

I've incorporated this into https://bugs.webkit.org/show_bug.cgi?id=134261 and given you credit.  It will be fixed once that clears all ews bots.

*** This bug has been marked as a duplicate of bug 134261 ***

(In reply to comment #4)
> I've incorporated this into https://bugs.webkit.org/show_bug.cgi?id=134261 and given you credit.  It will be fixed once that clears all ews bots.
> 

Sounds good, thanks :)

> *** This bug has been marked as a duplicate of bug 134261 ***