Bug 134106 - [Win] Menu list theme is not drawn.
Summary: [Win] Menu list theme is not drawn.
Status: RESOLVED DUPLICATE of bug 134261
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on: 134261
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-20 08:35 PDT by peavo
Modified: 2014-06-25 12:34 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.86 KB, patch)
2014-06-20 08:42 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-06-20 08:35:43 PDT
Dropdown menus are not rendered on Windows.
A virtual drawing method has changed signature, and the override on Windows needs updating.
Comment 1 peavo 2014-06-20 08:42:43 PDT
Created attachment 233429 [details]
Patch
Comment 2 Alex Christensen 2014-06-20 08:59:57 PDT
Comment on attachment 233429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review

> Source/WebCore/rendering/RenderThemeWin.cpp:803
> +    adjustMenuListButtonStyle(*styleResolver, *style, *e);

I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.
Comment 3 peavo 2014-06-20 11:25:29 PDT
(In reply to comment #2)
> (From update of attachment 233429 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review
> 

Thanks for looking into this :)

> > Source/WebCore/rendering/RenderThemeWin.cpp:803
> > +    adjustMenuListButtonStyle(*styleResolver, *style, *e);
> 
> I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.

I agree, could we perhaps address this in a separate patch, since it's a bigger change, involving all platforms?
Comment 4 Alex Christensen 2014-06-25 11:28:34 PDT
I've incorporated this into https://bugs.webkit.org/show_bug.cgi?id=134261 and given you credit.  It will be fixed once that clears all ews bots.

*** This bug has been marked as a duplicate of bug 134261 ***
Comment 5 peavo 2014-06-25 12:34:05 PDT
(In reply to comment #4)
> I've incorporated this into https://bugs.webkit.org/show_bug.cgi?id=134261 and given you credit.  It will be fixed once that clears all ews bots.
> 

Sounds good, thanks :)

> *** This bug has been marked as a duplicate of bug 134261 ***