Bug 134261 - use references instead of pointers in RenderTheme
Summary: use references instead of pointers in RenderTheme
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
: 134106 (view as bug list)
Depends on:
Blocks: 134106
  Show dependency tree / graph
 
Reported: 2014-06-24 12:05 PDT by Alex Christensen
Modified: 2014-06-25 14:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (89.02 KB, patch)
2014-06-24 12:06 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (150.92 KB, patch)
2014-06-24 15:38 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (173.29 KB, patch)
2014-06-24 16:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (204.89 KB, patch)
2014-06-24 16:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (206.11 KB, patch)
2014-06-24 16:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (210.91 KB, patch)
2014-06-24 17:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (213.82 KB, patch)
2014-06-24 22:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (215.64 KB, patch)
2014-06-25 09:48 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (215.73 KB, patch)
2014-06-25 10:00 PDT, Alex Christensen 		zalan: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-06-24 12:05:41 PDT 
There is inconsistent use of references, and I don't see any reason why there shouldn't be references.
Comment 1 Alex Christensen 2014-06-24 12:06:54 PDT 
Created attachment 233727 [details]
Patch
Comment 2 zalan 2014-06-24 12:48:45 PDT 
wait for the elf/gtk bots. they both have dependencies on the theme signature.
Comment 3 Alex Christensen 2014-06-24 15:38:37 PDT 
Created attachment 233754 [details]
Patch
Comment 4 Alex Christensen 2014-06-24 16:14:13 PDT 
Created attachment 233758 [details]
Patch
Comment 5 Alex Christensen 2014-06-24 16:46:41 PDT 
Created attachment 233764 [details]
Patch
Comment 6 Alex Christensen 2014-06-24 16:59:40 PDT 
Created attachment 233766 [details]
Patch
Comment 7 Alex Christensen 2014-06-24 17:36:39 PDT 
Created attachment 233769 [details]
Patch
Comment 8 zalan 2014-06-24 19:01:55 PDT 
one more to go :)
Comment 9 Alex Christensen 2014-06-24 22:11:02 PDT 
Created attachment 233787 [details]
Patch
Comment 10 Alex Christensen 2014-06-25 09:48:01 PDT 
Created attachment 233820 [details]
Patch
Comment 11 Alex Christensen 2014-06-25 10:00:26 PDT 
Created attachment 233822 [details]
Patch
Comment 12 Alex Christensen 2014-06-25 11:28:34 PDT 
*** Bug 134106 has been marked as a duplicate of this bug. ***
Comment 13 WebKit Commit Bot 2014-06-25 14:00:08 PDT 
Comment on attachment 233822 [details]
Patch

Rejecting attachment 233822 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 233822, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5171847423328256
Comment 14 Alex Christensen 2014-06-25 14:05:31 PDT 
http://trac.webkit.org/changeset/170435