Bug 134052 – MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL() leaks an NSMutableArray

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[David Kilzer (:ddkilzer)]

WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:688:43: warning: Potential leak of an object stored into 'outOfBandTracks'
        NSMutableArray* outOfBandTracks = [[NSMutableArray alloc] init];
                                          ^

[David Kilzer (:ddkilzer)]

Created attachment 233344 [details]
Patch v1

[WebKit Commit Bot]

Attachment 233344 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:694:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> Attachment 233344 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:694:  Missing space before {  [whitespace/braces] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Stylebot doesn't like Objective-C literal syntax.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (In reply to comment #2)
> > Attachment 233344 [details] [details] did not pass style-queue:
> > 
> > 
> > ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:694:  Missing space before {  [whitespace/braces] [5]
> > Total errors found: 1 in 2 files
> > 
> > 
> > If any of these errors are false positives, please file a bug against check-webkit-style.
> 
> Stylebot doesn't like Objective-C literal syntax.

Filed Bug 134061:  <https://bugs.webkit.org/show_bug.cgi?id=134061>

[WebKit Commit Bot]

Comment on attachment 233344 [details]
Patch v1

Clearing flags on attachment: 233344

Committed r170146: <http://trac.webkit.org/changeset/170146>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.