Bug 134061 - check-webkit-style does not understand Obj-C literal syntax for NSDictionary
Summary: check-webkit-style does not understand Obj-C literal syntax for NSDictionary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-19 08:48 PDT by David Kilzer (:ddkilzer)
Modified: 2014-06-19 10:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (2.77 KB, patch)
2014-06-19 09:24 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-06-19 08:48:14 PDT 
See Bug 134052 Comment #2 <https://bugs.webkit.org/show_bug.cgi?id=134052#c2>:

Attachment 233344 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:694:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 1 David Kilzer (:ddkilzer) 2014-06-19 09:24:04 PDT 
Created attachment 233363 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-06-19 10:48:53 PDT 
Comment on attachment 233363 [details]
Patch v1

Clearing flags on attachment: 233363

Committed r170152: <http://trac.webkit.org/changeset/170152>
Comment 3 WebKit Commit Bot 2014-06-19 10:48:56 PDT 
All reviewed patches have been landed.  Closing bug.