Bug 133991 - REGRESSION (r167856): Unable to log into HSBC app
Summary: REGRESSION (r167856): Unable to log into HSBC app
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-06-17 12:36 PDT by Daniel Bates
Modified: 2014-06-18 14:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch and layout tests (17.96 KB, patch)
2014-06-17 12:40 PDT, Daniel Bates
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-06-17 12:36:54 PDT
Following <http://trac.webkit.org/changeset/167856> (bug #132224) we disallow "navigation to any URL that is invalid, except for JavaScript URLs, which need not be valid." A byproduct of this decision is that we no longer notify the WebKit client when preparing to navigate to a URL if that URL is invalid. The native portion of the HSBC app on iOS expects to be notified when navigating to any URL, including an invalid URL of the form hsbc://A=a&B=b). But we no longer notify it of such URLs because we disallow navigating to them as of <http://trac.webkit.org/changeset/167856>.
Comment 1 Daniel Bates 2014-06-17 12:40:51 PDT
Created attachment 233250 [details]
Patch and layout tests
Comment 2 Daniel Bates 2014-06-17 12:42:11 PDT
<rdar://problem/17044839>
Comment 3 David Kilzer (:ddkilzer) 2014-06-18 14:33:05 PDT
Comment on attachment 233250 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=233250&action=review

r=me

> LayoutTests/fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt:11
> +Note, this test must be run in Dump Render Tree.

Nit: Usually we just say "DumpRenderTree".  If you change it here, please change it in all the tests and expected results.
Comment 4 Daniel Bates 2014-06-18 14:49:24 PDT
(In reply to comment #3)
> > LayoutTests/fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt:11
> > +Note, this test must be run in Dump Render Tree.
> 
> Nit: Usually we just say "DumpRenderTree".  If you change it here, please change it in all the tests and expected results.

Will substitute "DumpRenderTree" for "Dump Render Tree" in the included tests before landing.
Comment 5 Daniel Bates 2014-06-18 14:53:18 PDT
Committed r170120: <http://trac.webkit.org/changeset/170120>