Bug 133991 – REGRESSION (r167856): Unable to log into HSBC app

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Following <http://trac.webkit.org/changeset/167856> (bug #132224) we disallow "navigation to any URL that is invalid, except for JavaScript URLs, which need not be valid." A byproduct of this decision is that we no longer notify the WebKit client when preparing to navigate to a URL if that URL is invalid. The native portion of the HSBC app on iOS expects to be notified when navigating to any URL, including an invalid URL of the form hsbc://A=a&B=b). But we no longer notify it of such URLs because we disallow navigating to them as of <http://trac.webkit.org/changeset/167856>.

[Daniel Bates]

Created attachment 233250 [details]
Patch and layout tests

[Daniel Bates]

<rdar://problem/17044839>

[David Kilzer (:ddkilzer)]

Comment on attachment 233250 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=233250&action=review

r=me

> LayoutTests/fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt:11
> +Note, this test must be run in Dump Render Tree.

Nit: Usually we just say "DumpRenderTree".  If you change it here, please change it in all the tests and expected results.

[Daniel Bates]

(In reply to comment #3)
> > LayoutTests/fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt:11
> > +Note, this test must be run in Dump Render Tree.
> 
> Nit: Usually we just say "DumpRenderTree".  If you change it here, please change it in all the tests and expected results.

Will substitute "DumpRenderTree" for "Dump Render Tree" in the included tests before landing.

[Daniel Bates]

Committed r170120: <http://trac.webkit.org/changeset/170120>