Bug 133985 - [ftlopt] Get rid of NodeDoesNotExit and also get rid of StoreEliminationPhase
Summary: [ftlopt] Get rid of NodeDoesNotExit and also get rid of StoreEliminationPhase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
: 110383 130521 (view as bug list)
Depends on:
Blocks: 133918
  Show dependency tree / graph
 
Reported: 2014-06-17 10:33 PDT by Filip Pizlo
Modified: 2014-06-17 10:53 PDT (History)
7 users (show)

See Also:

Attachments
the patch (71.97 KB, patch)
2014-06-17 10:38 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-06-17 10:33:10 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-06-17 10:33:28 PDT 
*** Bug 130521 has been marked as a duplicate of this bug. ***
Comment 2 Filip Pizlo 2014-06-17 10:33:48 PDT 
*** Bug 110383 has been marked as a duplicate of this bug. ***
Comment 3 Filip Pizlo 2014-06-17 10:38:47 PDT 
Created attachment 233243 [details]
the patch
Comment 4 Michael Saboff 2014-06-17 10:45:33 PDT 
Comment on attachment 233243 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233243&action=review

r=me,  I like the read.  One typo.

> Source/JavaScriptCore/ChangeLog:18
> +        other optimizations that previously relied upomn NodeDoesNotExit.

*upon*
Comment 5 Mark Hahnenberg 2014-06-17 10:51:21 PDT 
Comment on attachment 233243 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233243&action=review

r=me too

> Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:91
>      // Indicate the start of execution of the node. It resets any state in the node,

s/node,$/node
Comment 6 Filip Pizlo 2014-06-17 10:53:21 PDT 
Landed in http://trac.webkit.org/changeset/170060