Bug 133646 - REGRESSION (r169681): Three tests are broken
Summary: REGRESSION (r169681): Three tests are broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on: 133612
  Show dependency treegraph
Reported: 2014-06-09 10:14 PDT by Alexey Proskuryakov
Modified: 2015-08-18 08:44 PDT (History)
5 users (show)

See Also:

proposed fix (16.46 KB, patch)
2014-06-09 10:20 PDT, Alexey Proskuryakov
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-06-09 10:14:14 PDT
<http://trac.webkit.org/changeset/169681> broke three tests on Mountain Lion and Mavericks:

Comment 1 Alexey Proskuryakov 2014-06-09 10:20:37 PDT
Created attachment 232709 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-06-09 10:22:55 PDT
Attachment 232709 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/RenderThemeMac.h:125:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/rendering/RenderThemeMac.h:166:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-06-09 11:38:26 PDT
Comment on attachment 232709 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=232709&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:305
> +int RenderThemeMac::platformFocusRingMaxWidth() const

should we rename this to be platformFocusRingMinWidth, since it is max'd with the actual width?
Comment 4 Alexey Proskuryakov 2014-06-09 11:45:06 PDT
Committed <http://trac.webkit.org/r169699>
Comment 5 zalan 2015-08-18 08:44:45 PDT
FYI: http://trac.webkit.org/changeset/188577