Bug 133612 - Regression r168397 - Form layout is incorrect on OS X Yosemite
Summary: Regression r168397 - Form layout is incorrect on OS X Yosemite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks: 133646
  Show dependency tree / graph
 
Reported: 2014-06-07 15:55 PDT by Dean Jackson
Modified: 2014-06-09 10:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.74 KB, patch)
2014-06-07 16:00 PDT, Dean Jackson 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-06-07 15:55:27 PDT 
Regression r168397 - Form layout is incorrect on OS X Yosemite
Comment 1 Dean Jackson 2014-06-07 16:00:58 PDT 
Created attachment 232671 [details]
Patch
Comment 2 Anders Carlsson 2014-06-07 16:21:23 PDT 
Comment on attachment 232671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232671&action=review

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:71
> +    return wkDrawFocusRingAtTime(context, DBL_MAX);

Please use std::numeric_limits<double>::max() here.

> Source/WebCore/platform/mac/ThemeMac.mm:379
> +    wkDrawCellFocusRingWithFrameAtTime(cell, cellFrame, controlView, DBL_MAX);

Same thing here.

> Source/WebCore/rendering/RenderThemeMac.mm:928
> +        if (wkDrawCellFocusRingWithFrameAtTime(popupButton, inflatedRect, view, DBL_MAX))

And here.
Comment 3 Dean Jackson 2014-06-07 16:26:21 PDT 
Committed r169681: <http://trac.webkit.org/changeset/169681>
Comment 4 Alexey Proskuryakov 2014-06-09 09:53:57 PDT 
This broke three tests on Mavericks and Mountain Lion at least (not sure about Yosemite):

compositing/geometry/ancestor-overflow-change.html
compositing/layer-creation/overlap-animation-container.html
platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html
Comment 5 Alexey Proskuryakov 2014-06-09 10:14:32 PDT 
Fixing in bug 133646.