WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133438
DYEBench: Move test states into benchmarkClient and remove the closure
https://bugs.webkit.org/show_bug.cgi?id=133438
Summary
DYEBench: Move test states into benchmarkClient and remove the closure
Ryosuke Niwa
Reported
2014-06-01 13:52:01 PDT
The local variables in the closure used to keep states for benchmarkClient is making the code less comprehensible. Move them onto benchmarkClient itself.
Attachments
Cleanup
(6.27 KB, patch)
2014-06-01 13:54 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Reverted the erroneous change to the number of iterations
(6.25 KB, patch)
2014-06-01 13:57 PDT
,
Ryosuke Niwa
benjamin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2014-06-01 13:54:36 PDT
Created
attachment 232355
[details]
Cleanup
Ryosuke Niwa
Comment 2
2014-06-01 13:57:41 PDT
Created
attachment 232356
[details]
Reverted the erroneous change to the number of iterations
Ryosuke Niwa
Comment 3
2014-06-01 14:12:04 PDT
Thanks again!
Ryosuke Niwa
Comment 4
2014-06-01 14:12:27 PDT
Committed
r169517
: <
http://trac.webkit.org/changeset/169517
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug