Bug 133438 - DYEBench: Move test states into benchmarkClient and remove the closure
Summary: DYEBench: Move test states into benchmarkClient and remove the closure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 133437
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-01 13:52 PDT by Ryosuke Niwa
Modified: 2014-06-01 14:12 PDT (History)
5 users (show)

See Also:

Attachments
Cleanup (6.27 KB, patch)
2014-06-01 13:54 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Reverted the erroneous change to the number of iterations (6.25 KB, patch)
2014-06-01 13:57 PDT, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-06-01 13:52:01 PDT 
The local variables in the closure used to keep states for benchmarkClient is making the code less comprehensible.
Move them onto benchmarkClient itself.
Comment 1 Ryosuke Niwa 2014-06-01 13:54:36 PDT 
Created attachment 232355 [details]
Cleanup
Comment 2 Ryosuke Niwa 2014-06-01 13:57:41 PDT 
Created attachment 232356 [details]
Reverted the erroneous change to the number of iterations
Comment 3 Ryosuke Niwa 2014-06-01 14:12:04 PDT 
Thanks again!
Comment 4 Ryosuke Niwa 2014-06-01 14:12:27 PDT 
Committed r169517: <http://trac.webkit.org/changeset/169517>