Bug 133437 - DYEBench: Split stylesheets and scripts in Full.html into separate files
Summary: DYEBench: Split stylesheets and scripts in Full.html into separate files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 133438
  Show dependency tree / graph
 
Reported: 2014-06-01 13:08 PDT by Ryosuke Niwa
Modified: 2014-06-01 13:52 PDT (History)
5 users (show)

See Also:

Attachments
Cleanup and fixes one bug along the way (9.48 KB, patch)
2014-06-01 13:11 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Revised the change log entry (9.28 KB, patch)
2014-06-01 13:15 PDT, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-06-01 13:08:11 PDT 
There's no need in keeping all of them in one file.
Comment 1 Ryosuke Niwa 2014-06-01 13:11:26 PDT 
Created attachment 232352 [details]
Cleanup and fixes one bug along the way
Comment 2 Ryosuke Niwa 2014-06-01 13:15:46 PDT 
Created attachment 232353 [details]
Revised the change log entry
Comment 3 Ryosuke Niwa 2014-06-01 13:16:53 PDT 
Comment on attachment 232353 [details]
Revised the change log entry

View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review

> PerformanceTests/DoYouEvenBench/resources/main.js:3
> +(function () {
> +
> +var values = [];

I've purposefully kept this unintended so that I can do the planned refactoring in the next patch without completely messing up the diff.
Comment 4 Ryosuke Niwa 2014-06-01 13:18:29 PDT 
Comment on attachment 232353 [details]
Revised the change log entry

View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review

>> PerformanceTests/DoYouEvenBench/resources/main.js:3
>> +var values = [];
> 
> I've purposefully kept this unintended so that I can do the planned refactoring in the next patch without completely messing up the diff.

Namely, I'd like to move all these local variables into benchmarkClient and avoid using the closure altogether.
Comment 5 Benjamin Poulain 2014-06-01 13:33:14 PDT 
Comment on attachment 232353 [details]
Revised the change log entry

View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review

> PerformanceTests/DoYouEvenBench/Full.html:11
> +    <script src="resources/main.js"></script>
> +    <script src="resources/benchmark-runner.js"></script>
> +    <script src="resources/benchmark-report.js"></script>
> +    <script src="../resources/statistics.js"></script>
> +    <script src="resources/tests.js"></script>

Can anything be made async/defer?
Comment 6 Ryosuke Niwa 2014-06-01 13:36:42 PDT 
(In reply to comment #5)
> (From update of attachment 232353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review
> 
> > PerformanceTests/DoYouEvenBench/Full.html:11
> > +    <script src="resources/main.js"></script>
> > +    <script src="resources/benchmark-runner.js"></script>
> > +    <script src="resources/benchmark-report.js"></script>
> > +    <script src="../resources/statistics.js"></script>
> > +    <script src="resources/tests.js"></script>
> 
> Can anything be made async/defer?

Sure, we can use defer.   Thanks for the review!
Comment 7 Ryosuke Niwa 2014-06-01 13:39:22 PDT 
Committed r169516: <http://trac.webkit.org/changeset/169516>