Bug 133437 – DYEBench: Split stylesheets and scripts in Full.html into separate files

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

There's no need in keeping all of them in one file.

[Ryosuke Niwa]

Created attachment 232352 [details]
Cleanup and fixes one bug along the way

[Ryosuke Niwa]

Created attachment 232353 [details]
Revised the change log entry

[Ryosuke Niwa]

Comment on attachment 232353 [details]
Revised the change log entry

View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review

> PerformanceTests/DoYouEvenBench/resources/main.js:3
> +(function () {
> +
> +var values = [];

I've purposefully kept this unintended so that I can do the planned refactoring in the next patch without completely messing up the diff.

[Ryosuke Niwa]

Comment on attachment 232353 [details]
Revised the change log entry

View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review

>> PerformanceTests/DoYouEvenBench/resources/main.js:3
>> +var values = [];
> 
> I've purposefully kept this unintended so that I can do the planned refactoring in the next patch without completely messing up the diff.

Namely, I'd like to move all these local variables into benchmarkClient and avoid using the closure altogether.

[Benjamin Poulain]

Comment on attachment 232353 [details]
Revised the change log entry

View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review

> PerformanceTests/DoYouEvenBench/Full.html:11
> +    <script src="resources/main.js"></script>
> +    <script src="resources/benchmark-runner.js"></script>
> +    <script src="resources/benchmark-report.js"></script>
> +    <script src="../resources/statistics.js"></script>
> +    <script src="resources/tests.js"></script>

Can anything be made async/defer?

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 232353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232353&action=review
> 
> > PerformanceTests/DoYouEvenBench/Full.html:11
> > +    <script src="resources/main.js"></script>
> > +    <script src="resources/benchmark-runner.js"></script>
> > +    <script src="resources/benchmark-report.js"></script>
> > +    <script src="../resources/statistics.js"></script>
> > +    <script src="resources/tests.js"></script>
> 
> Can anything be made async/defer?

Sure, we can use defer.   Thanks for the review!

[Ryosuke Niwa]

Committed r169516: <http://trac.webkit.org/changeset/169516>