Bug 133327 – run web timing tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

We should run the web timing tests if web timing is enabled.

[Alex Christensen]

Created attachment 232158 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 232158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review

> LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34
> +    for (var key in timing) {
> +        keys.push(key);
> +    }

No curly brackets for single line statements.

> LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11
> +    for (var property in timing) {
> +        properties.push(property);
> +    }

Ditto.

> LayoutTests/platform/mac/TestExpectations:193
> +# Resource Timing is not enabled.
> +# https://bugs.webkit.org/show_bug.cgi?id=133321
>  http/tests/w3c/webperf

Shouldn't we also disable this on ML and Mavericks?

[Alex Christensen]

(In reply to comment #2)
> (From update of attachment 232158 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review
> 
> > LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34
> > +    for (var key in timing) {
> > +        keys.push(key);
> > +    }
> 
> No curly brackets for single line statements.
Done.
> 
> > LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11
> > +    for (var property in timing) {
> > +        properties.push(property);
> > +    }
> 
> Ditto.
Done.
> 
> > LayoutTests/platform/mac/TestExpectations:193
> > +# Resource Timing is not enabled.
> > +# https://bugs.webkit.org/show_bug.cgi?id=133321
> >  http/tests/w3c/webperf
> 
> Shouldn't we also disable this on ML and Mavericks?
This needs to stay disabled until RESOURCE_TIMING is enabled and tested.

http://trac.webkit.org/changeset/169403