Bug 133327 - run web timing tests
Summary: run web timing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-27 15:56 PDT by Alex Christensen
Modified: 2014-05-27 16:34 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.46 KB, patch)
2014-05-27 16:00 PDT, Alex Christensen
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-05-27 15:56:55 PDT
We should run the web timing tests if web timing is enabled.
Comment 1 Alex Christensen 2014-05-27 16:00:40 PDT
Created attachment 232158 [details]
Patch
Comment 2 Ryosuke Niwa 2014-05-27 16:18:56 PDT
Comment on attachment 232158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review

> LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34
> +    for (var key in timing) {
> +        keys.push(key);
> +    }

No curly brackets for single line statements.

> LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11
> +    for (var property in timing) {
> +        properties.push(property);
> +    }

Ditto.

> LayoutTests/platform/mac/TestExpectations:193
> +# Resource Timing is not enabled.
> +# https://bugs.webkit.org/show_bug.cgi?id=133321
>  http/tests/w3c/webperf

Shouldn't we also disable this on ML and Mavericks?
Comment 3 Alex Christensen 2014-05-27 16:34:04 PDT
(In reply to comment #2)
> (From update of attachment 232158 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review
> 
> > LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34
> > +    for (var key in timing) {
> > +        keys.push(key);
> > +    }
> 
> No curly brackets for single line statements.
Done.
> 
> > LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11
> > +    for (var property in timing) {
> > +        properties.push(property);
> > +    }
> 
> Ditto.
Done.
> 
> > LayoutTests/platform/mac/TestExpectations:193
> > +# Resource Timing is not enabled.
> > +# https://bugs.webkit.org/show_bug.cgi?id=133321
> >  http/tests/w3c/webperf
> 
> Shouldn't we also disable this on ML and Mavericks?
This needs to stay disabled until RESOURCE_TIMING is enabled and tested.

http://trac.webkit.org/changeset/169403