RESOLVED FIXED Bug 133281
[CSS Box Alignment] Implement justify-self and justify-item css properties. 
https://bugs.webkit.org/show_bug.cgi?id=133281
Summary [CSS Box Alignment] Implement justify-self and justify-item css properties.
Javier Fernandez
Reported 2014-05-26 03:55:01 PDT
These two properties are defined in the CSS Box Alignment Module Level 3, bit still not supported in WebKit. Both should be supported by the CSS Grid Layout standard and they would be quite useful for the grid related use cases, so I think it's now time to implement them in WebKit. Later, we will have to add the required support in the grid implementation (bug #133280)
Attachments
Patch (49.96 KB, patch)
2015-03-30 14:33 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (51.87 KB, patch)
2015-03-30 14:41 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (665.28 KB, application/zip)
2015-03-30 15:41 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews102 for mac-mavericks (611.14 KB, application/zip)
2015-03-30 16:08 PDT, Build Bot 		no flags
Details
Patch (53.37 KB, patch)
2015-03-31 05:08 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2015-03-30 14:33:09 PDT
Created attachment 249762 [details] Patch
Javier Fernandez
Comment 2 2015-03-30 14:41:10 PDT
Created attachment 249765 [details] Patch
Build Bot
Comment 3 2015-03-30 15:41:35 PDT
Comment on attachment 249765 [details] Patch Attachment 249765 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6605964031557632 New failing tests: svg/css/getComputedStyle-basic.xhtml
Build Bot
Comment 4 2015-03-30 15:41:39 PDT
Created attachment 249776 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-03-30 16:08:30 PDT
Comment on attachment 249765 [details] Patch Attachment 249765 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5671725966557184 New failing tests: svg/css/getComputedStyle-basic.xhtml
Build Bot
Comment 6 2015-03-30 16:08:34 PDT
Created attachment 249779 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Javier Fernandez
Comment 7 2015-03-31 05:08:08 PDT
Created attachment 249820 [details] Patch
Dave Hyatt
Comment 8 2015-04-09 15:48:40 PDT
Comment on attachment 249820 [details] Patch r=me
WebKit Commit Bot
Comment 9 2015-04-09 16:37:25 PDT
Comment on attachment 249820 [details] Patch Clearing flags on attachment: 249820 Committed r182613: <http://trac.webkit.org/changeset/182613>
WebKit Commit Bot
Comment 10 2015-04-09 16:37:31 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 11 2015-04-09 20:16:36 PDT
This may have caused some test failures: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r182613%20(3666)/results.html
Javier Fernandez
Comment 12 2015-04-10 02:19:22 PDT
umm, sorry but I don't see the relation of my patch with such failures. Why do you think this patch may have caused them ?
Note You need to log in before you can comment on or make changes to this bug.