Bug 133099 - WebKit2/iOS: parented view should be considered hidden if app is backgrounded
Summary: WebKit2/iOS: parented view should be considered hidden if app is backgrounded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 17:35 PDT by Gavin Barraclough
Modified: 2014-05-19 19:23 PDT (History)
1 user (show)

See Also:

Attachments
Fix (4.40 KB, patch)
2014-05-19 17:58 PDT, Gavin Barraclough 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-05-19 17:35:59 PDT 
.
Comment 1 Gavin Barraclough 2014-05-19 17:58:54 PDT 
Created attachment 231743 [details]
Fix
Comment 2 Simon Fraser (smfr) 2014-05-19 18:09:41 PDT 
Comment on attachment 231743 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review

> Source/WebKit2/ChangeLog:3
> +        WebKit2/iOS: view is not visible if app is not foreground.

Please update from the bugzilla.
Is there a relevant radar?

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111
>  bool PageClientImpl::isViewWindowActive()

isViewsWindowActive?

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114
> +    return isViewVisible();

Not clear what the implications of isViewWindowActive are.
Comment 3 Gavin Barraclough 2014-05-19 18:55:52 PDT 
(In reply to comment #2)
> (From update of attachment 231743 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        WebKit2/iOS: view is not visible if app is not foreground.
> 
> Please update from the bugzilla.

fixed

> Is there a relevant radar?

fixed

> > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111
> >  bool PageClientImpl::isViewWindowActive()
> 
> isViewsWindowActive?

I'll follow up in a separate change (per our discussion I'll probably remove outright).

> > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114
> > +    return isViewVisible();
> 
> Not clear what the implications of isViewWindowActive are.

Agreed! - filed https://bugs.webkit.org/show_bug.cgi?id=133098 to track this.
Comment 4 Gavin Barraclough 2014-05-19 19:23:14 PDT 
Transmitting file data ...
Committed revision 169095.