Bug 133099 – WebKit2/iOS: parented view should be considered hidden if app is backgrounded

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gavin Barraclough]

.

[Gavin Barraclough]

Created attachment 231743 [details]
Fix

[Simon Fraser (smfr)]

Comment on attachment 231743 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review

> Source/WebKit2/ChangeLog:3
> +        WebKit2/iOS: view is not visible if app is not foreground.

Please update from the bugzilla.
Is there a relevant radar?

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111
>  bool PageClientImpl::isViewWindowActive()

isViewsWindowActive?

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114
> +    return isViewVisible();

Not clear what the implications of isViewWindowActive are.

[Gavin Barraclough]

(In reply to comment #2)
> (From update of attachment 231743 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        WebKit2/iOS: view is not visible if app is not foreground.
> 
> Please update from the bugzilla.

fixed

> Is there a relevant radar?

fixed

> > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111
> >  bool PageClientImpl::isViewWindowActive()
> 
> isViewsWindowActive?

I'll follow up in a separate change (per our discussion I'll probably remove outright).

> > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114
> > +    return isViewVisible();
> 
> Not clear what the implications of isViewWindowActive are.

Agreed! - filed https://bugs.webkit.org/show_bug.cgi?id=133098 to track this.

[Gavin Barraclough]

Transmitting file data ...
Committed revision 169095.