Bug 132983 - [EFL][WK2] test_ewk2_view is failed
Summary: [EFL][WK2] test_ewk2_view is failed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 132813
  Show dependency treegraph
 
Reported: 2014-05-15 18:15 PDT by Gyuyoung Kim
Modified: 2014-10-02 04:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.95 KB, patch)
2014-05-16 03:56 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2014-10-01 07:39 PDT, Ryuan Choi
gyuyoung.kim: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-05-15 18:15:56 PDT
[ RUN      ] EWK2ViewTest.ewk_view_theme_set
/mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:393: Failure
Value of: waitUntilTitleChangedTo("30")
  Actual: false
Expected: true
Comment 1 Gyuyoung Kim 2014-05-16 03:56:56 PDT
Created attachment 231565 [details]
Patch
Comment 2 Chris Dumez 2014-05-16 06:11:24 PDT
Comment on attachment 231565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231565&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-483
> -    EXPECT_TRUE(waitUntilTitleChangedTo("Title after changed"));

Why was this timing out? The test looked correct even though it is true we were checking the title twice. However, the test was supposed to pass and now it looks like we are hiding / working around the problem?
Comment 3 Gyuyoung Kim 2014-05-16 06:20:37 PDT
(In reply to comment #2)
> (From update of attachment 231565 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231565&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-483
> > -    EXPECT_TRUE(waitUntilTitleChangedTo("Title after changed"));
> 
> Why was this timing out? The test looked correct even though it is true we were checking the title twice. However, the test was supposed to pass and now it looks like we are hiding / working around the problem?

Yes, ryuan already noticed it privately. I didn't update it to the patch. ;) patch will be updated again.
Comment 4 Ryuan Choi 2014-08-06 00:33:20 PDT
Was this flaky or raised at the only the bot?

I run test_ewk2_view in my local and it looks fine.
(There are another failures which is related to Bug 133378 but others are fine).
Comment 5 Ryuan Choi 2014-10-01 07:39:40 PDT
Created attachment 239026 [details]
Patch
Comment 6 Gyuyoung Kim 2014-10-02 02:29:37 PDT
Comment on attachment 239026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239026&action=review

> Source/WebKit2/ChangeLog:8
> +        Enables test_ewk2_view because test cases of test_ewk2_view are passed except few tests which

Looks better below sentence.

"Enable test_ewk2_view because some test cases of test_ewk2_view are passed except for few tests related to device_pixel_ratio."
Comment 7 Ryuan Choi 2014-10-02 04:15:00 PDT
Committed r174208: <http://trac.webkit.org/changeset/174208>