Bug 132983 – [EFL][WK2] test_ewk2_view is failed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

[ RUN      ] EWK2ViewTest.ewk_view_theme_set
/mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:393: Failure
Value of: waitUntilTitleChangedTo("30")
  Actual: false
Expected: true

[Gyuyoung Kim]

Created attachment 231565 [details]
Patch

[Chris Dumez]

Comment on attachment 231565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231565&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-483
> -    EXPECT_TRUE(waitUntilTitleChangedTo("Title after changed"));

Why was this timing out? The test looked correct even though it is true we were checking the title twice. However, the test was supposed to pass and now it looks like we are hiding / working around the problem?

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 231565 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231565&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-483
> > -    EXPECT_TRUE(waitUntilTitleChangedTo("Title after changed"));
> 
> Why was this timing out? The test looked correct even though it is true we were checking the title twice. However, the test was supposed to pass and now it looks like we are hiding / working around the problem?

Yes, ryuan already noticed it privately. I didn't update it to the patch. ;) patch will be updated again.

[Ryuan Choi]

Was this flaky or raised at the only the bot?

I run test_ewk2_view in my local and it looks fine.
(There are another failures which is related to Bug 133378 but others are fine).

[Ryuan Choi]

Created attachment 239026 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 239026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239026&action=review

> Source/WebKit2/ChangeLog:8
> +        Enables test_ewk2_view because test cases of test_ewk2_view are passed except few tests which

Looks better below sentence.

"Enable test_ewk2_view because some test cases of test_ewk2_view are passed except for few tests related to device_pixel_ratio."

[Ryuan Choi]

Committed r174208: <http://trac.webkit.org/changeset/174208>