I know we can't do it ATM, but this bug will also work as reminder to remove all the ifdefs we currently have, and that we will be able to remove once we bump the cairo requirements.
Do we have an specific bug in cairo to follow?
Cairo already supports it, but in snapshots releases.
I don't think we can raise our requirements until 4.x.
I think we can close this issue as obsolete: We have had code in “Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp” to set the device scale factor for Cairo surfaces for a good while, which is used conditionally if Cairo 1.13 or newer is being used. Or is there something else that needs to be done in this regard?
This is about bumping cairo requirement and remove the ifdefs we currently have to support HiDPI.
(In reply to Carlos Garcia Campos from comment #5) > This is about bumping cairo requirement and remove the ifdefs we currently > have to support HiDPI. Ah, I get it know. I'll check later what versions distributions are using and see whether it would possible to bump the requirement, taking https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy into account 👍️
(In reply to Adrian Perez from comment #6) > (In reply to Carlos Garcia Campos from comment #5) > > This is about bumping cairo requirement and remove the ifdefs we currently > > have to support HiDPI. > > Ah, I get it know. I'll check later what versions distributions are > using and see whether it would possible to bump the requirement, > taking https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy > into account 👍️ - Debian Stretch, supported until August 2021, has Cairo 1.14.8: https://packages.debian.org/stretch/libcairo2 - Ubuntu LTS 18.04, supported until April 2021, has Cairo 1.15.10: https://packages.ubuntu.com/bionic/libcairo2 So yes, it looks like we can bump the minimum Cairo requirement to 1.14.x and remove the conditional compilation guards 🙌️
(In reply to Adrian Perez from comment #7) > (In reply to Adrian Perez from comment #6) > > (In reply to Carlos Garcia Campos from comment #5) > > > This is about bumping cairo requirement and remove the ifdefs we currently > > > have to support HiDPI. > > > > Ah, I get it know. I'll check later what versions distributions are > > using and see whether it would possible to bump the requirement, > > taking https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy > > into account 👍️ > > - Debian Stretch, supported until August 2021, has Cairo 1.14.8: > https://packages.debian.org/stretch/libcairo2 > - Ubuntu LTS 18.04, supported until April 2021, has Cairo 1.15.10: > https://packages.ubuntu.com/bionic/libcairo2 > > So yes, it looks like we can bump the minimum Cairo requirement to 1.14.x > and remove the conditional compilation guards 🙌️ Funny story: in “Source/cmake/Options{GTK,WPE}.cmake” we are already listing 1.14.0 as the minimum required Cairo version.
Created attachment 409326 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
CC'ing Don Olmstead as well… is this okay for the PlayStation port? In “OptionsPlayStation.cmake” there is no minimum version being requested for Cairo, should I add 1.14.0 there as well?
Committed r267398: <https://trac.webkit.org/changeset/267398> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409326 [details].