NEW 132303
Fix a failure with python3 
https://bugs.webkit.org/show_bug.cgi?id=132303
Summary Fix a failure with python3
Jerome Leclanche
Reported 2014-04-28 14:33:59 PDT
Created attachment 230323 [details] Patch Same logic as with bug 106645. Please forgive the non-svn diff, I'm on a terrible connection at the moment and unable to download the full webkit sources. Fixes the following failure: File ".../JavaScriptCore/disassembler/udis86/itab.py", line 347, in genItab self.genItabH() File ".../JavaScriptCore/disassembler/udis86/itab.py", line 318, in genItabH operands.sort() AttributeError: 'dict_keys' object has no attribute 'sort' Makefile.JavaScriptCore.DerivedSources:730: recipe for target 'generated/udis86_itab.c' failed make[2]: *** [generated/udis86_itab.c] Error 1
Attachments
Patch (527 bytes, patch)
2014-04-28 14:33 PDT, Jerome Leclanche 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jerome Leclanche
Comment 1 2014-04-28 14:44:24 PDT
This could actually just be updated against upstream, by the way. https://github.com/vmt/udis86/blob/master/scripts/ud_itab.py
WebKit Commit Bot
Comment 2 2014-04-28 14:51:13 PDT
Attachment 230323 [details] did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.