Bug 106645 – Failure building with python3

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Laszlo Papp]

See the patch for addressing the python3 issue.

[Laszlo Papp]

Created attachment 182300 [details]
print-function-usage-patch

[Andras Becsi]

Comment on attachment 182300 [details]
print-function-usage-patch

This patch misses a ChangeLog. Please refer to http://www.webkit.org/coding/contributing.html for more information.

Also, please set review? and commit-queue? if you'd like your patch to be reviewed and committed.

[Bruno Abinader (history only)]

Hi Laszlo :) Good to see you around WebKit! Please let me give you a few hints on how WebKit patches should look like:

- Every WebKit patch should contain at least one ChangeLog entry, with respect to the subdirectory the modifications were made (ie. Source/JavaScriptCore/ChangeLog).

- The ChangeLog entry should follow the guideline described in [1]. You can take advantage of a script called 'Tools/Scripts/prepare-ChangeLog -g HEAD', where HEAD is the top of your git branch, for example.

Links:
[1] http://www.webkit.org/coding/contributing.html#changelogs

[Simon Hausmann]

I've submitted your patch to the EWS to see if there are any technical issues with it from a building POV, but yeah, as Andras and Bruno point out: The patch needs a ChangeLog.

The workflow I would recommend is to run

(1) Tools/Scripts/webkit-patch prepare 106645
(2) Then complete the editing of the ChangeLog files prepared by the above command
(3) Tools/Scripts/webkit-patch post --request-commit

That'll upload a new patch into this bug report and set the request review/commit flags accordingly, so that the patch can be processed for review and submission.

[WebKit Review Bot]

Attachment 182300 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/disassembler/udis86/..." exit_code: 1
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:228:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:229:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:231:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_optable.py:89:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_optable.py:91:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/itab.py:277:  [UdItabGenerator.genInsnTable] Using variable 'pfx' before assignment  [pylint/E0601] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Laszlo Papp]

Created attachment 184403 [details]
Updated change with changelog

@Simon:  Tools/Scripts/webkit-patch prepare 106645
Can't find a branch to diff against. svn-remote.svn.fetch is not in the git config and refs/remotes/origin/master does not exist
Can't find a branch to diff against. svn-remote.svn.fetch is not in the git config and refs/remotes/origin/master does not exist

[Benjamin Poulain]

Comment on attachment 184403 [details]
Updated change with changelog

Wrong patch format + wrong attachment flags.

[Laszlo Papp]

What do you mean by wrong patch format?

[Benjamin Poulain]

(In reply to comment #8)
> What do you mean by wrong patch format?

Here are the problem bugzilla had with the patch:
-You uploaded it with a binary MIME type.
-You did not check the patch checkbox, which means you did not agree on the project policies when uploading.
-You uploaded a Git email patch. I am not sure our patcher supports that.

[Laszlo Papp]

'git format-patch' is not supported? Then 'git diff' perhaps?

These automated scripts do not seem to work on my machine.

[Benjamin Poulain]

(In reply to comment #10)
> 'git format-patch' is not supported? Then 'git diff' perhaps?
> 
> These automated scripts do not seem to work on my machine.

Git diff works for sure.

Git format-patch may work but I am not certain. Most tools are for SVN and some have quirks with git output. Actually, given your first patch went fine through the bots, I think that should work just fine.

The important part is check the "Patch" checkbox when you upload. That should also set the mimetype correctly. :)

[Zan Dobersek]

Can we get this patch rolling again? It still applies properly (apart from the ChangeLog entry), it just needs to be reuploaded properly.

[Laszlo Papp]

@Zan: fix the tools to work, and then the contributors' life become simpler to update changes.

As for me, those tools were broken, so I lost my motivation to do the stuff manually without much experience.

[Zan Dobersek]

Created attachment 209451 [details]
Patch

[WebKit Commit Bot]

Attachment 209451 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/itab.py', u'Source/JavaScriptCore/disassembler/udis86/ud_opcode.py', u'Source/JavaScriptCore/disassembler/udis86/ud_optable.py']" exit_code: 1
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:228:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:229:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:231:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_optable.py:89:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_optable.py:91:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/itab.py:277:  [UdItabGenerator.genInsnTable] Using variable 'pfx' before assignment  [pylint/E0601] [5]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

(In reply to comment #13)
> @Zan: fix the tools to work, and then the contributors' life become simpler to update changes.
> 
> As for me, those tools were broken, so I lost my motivation to do the stuff manually without much experience.

As was explained, uploading the `git diff` output would work just well.
If you've experienced incorrect tool behavior, please file bugs about it.

I've reuploaded the patch, still listing you as the patch author, so it can run through the EWS and get reviewed.

[Zan Dobersek]

Created attachment 209453 [details]
With fixed ChangeLog

The ChangeLog was a bit out of form.

[WebKit Commit Bot]

Attachment 209453 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/disassembler/udis86/itab.py', u'Source/JavaScriptCore/disassembler/udis86/ud_opcode.py', u'Source/JavaScriptCore/disassembler/udis86/ud_optable.py']" exit_code: 1
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:228:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:229:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_opcode.py:231:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_optable.py:89:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/ud_optable.py:91:  whitespace after '('  [pep8/E201] [5]
Source/JavaScriptCore/disassembler/udis86/itab.py:277:  [UdItabGenerator.genInsnTable] Using variable 'pfx' before assignment  [pylint/E0601] [5]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 209453 [details]
With fixed ChangeLog

Clearing flags on attachment: 209453

Committed r154521: <http://trac.webkit.org/changeset/154521>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.