Bug 131557 - check-webkit-style should skip in-tree bindings tests results
Summary: check-webkit-style should skip in-tree bindings tests results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-11 12:33 PDT by Brian Burg
Modified: 2014-04-14 10:07 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-11 12:33:50 PDT
Whenever you rebaseline results, the style bot complains about generated code. e.g, <https://bugs.webkit.org/show_bug.cgi?id=131407>
Comment 1 Brian Burg 2014-04-13 12:48:35 PDT
I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py
Comment 2 Csaba Osztrogonác 2014-04-14 01:22:50 PDT
(In reply to comment #1)
> I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py

Yes, it can works. But I prefer fixing the generator 
instead of disabling style checker for these files.

I don't like 5-space indentation. :-/
Comment 3 Csaba Osztrogonác 2014-04-14 02:27:50 PDT
(In reply to comment #2)
> (In reply to comment #1)
> > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py
> 
> Yes, it can works. But I prefer fixing the generator 
> instead of disabling style checker for these files.
> 
> I don't like 5-space indentation. :-/

The bug isn't in check-webkit-style, but the change in code generator
which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521
Comment 4 Peter Molnar 2014-04-14 05:23:45 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py
> > 
> > Yes, it can works. But I prefer fixing the generator 
> > instead of disabling style checker for these files.
> > 
> > I don't like 5-space indentation. :-/
> 
> The bug isn't in check-webkit-style, but the change in code generator
> which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521

Created a fix for the code generator: https://bugs.webkit.org/show_bug.cgi?id=131613
Comment 5 Brian Burg 2014-04-14 10:07:08 PDT
Oops, I guess it was my fault all along. Thanks everyone.