RESOLVED FIXED 131557
check-webkit-style should skip in-tree bindings tests results 
https://bugs.webkit.org/show_bug.cgi?id=131557
Summary check-webkit-style should skip in-tree bindings tests results
Brian Burg
Reported 2014-04-11 12:33:50 PDT
Whenever you rebaseline results, the style bot complains about generated code. e.g, <https://bugs.webkit.org/show_bug.cgi?id=131407>
Attachments
Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-04-13 12:48:35 PDT
I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py
Csaba Osztrogonác
Comment 2 2014-04-14 01:22:50 PDT
(In reply to comment #1) > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py Yes, it can works. But I prefer fixing the generator instead of disabling style checker for these files. I don't like 5-space indentation. :-/
Csaba Osztrogonác
Comment 3 2014-04-14 02:27:50 PDT
(In reply to comment #2) > (In reply to comment #1) > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py > > Yes, it can works. But I prefer fixing the generator > instead of disabling style checker for these files. > > I don't like 5-space indentation. :-/ The bug isn't in check-webkit-style, but the change in code generator which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521
Peter Molnar
Comment 4 2014-04-14 05:23:45 PDT
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py > > > > Yes, it can works. But I prefer fixing the generator > > instead of disabling style checker for these files. > > > > I don't like 5-space indentation. :-/ > > The bug isn't in check-webkit-style, but the change in code generator > which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521 Created a fix for the code generator: https://bugs.webkit.org/show_bug.cgi?id=131613
Brian Burg
Comment 5 2014-04-14 10:07:08 PDT
Oops, I guess it was my fault all along. Thanks everyone.
Note You need to log in before you can comment on or make changes to this bug.