Bug 131407 – Web Replay: CodeGeneratorJS should guard includes of replay-related headers

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Brian Burg]

Missed this before because the old branch was never built on non-replay ports, or something. Also will move generated replay memoization code from DEFINE_STATIC_LOCAL to NeverDestroyed.

[Brian Burg]

Created attachment 228917 [details]
the patch

[WebKit Commit Bot]

Attachment 228917 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.h:118:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:172:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:174:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:206:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:208:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:240:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:242:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:276:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:312:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:314:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:429:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:457:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 13 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brian Burg]

Anders, does NeverDestroyed play nice with AtomicString?

[Brian Burg]

(In reply to comment #3)
> Anders, does NeverDestroyed play nice with AtomicString?

There are ~15 uses of NeverDestroyed<const AtomicString> in the codebase and ~90 uses of NeverDestroyed<AtomicString>. So, if it is an anti-pattern, there's some more cleanup to do.

[Joseph Pecoraro]

Comment on attachment 228917 [details]
the patch

Patch looks good to me.

[WebKit Commit Bot]

Comment on attachment 228917 [details]
the patch

Clearing flags on attachment: 228917

Committed r167140: <http://trac.webkit.org/changeset/167140>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.