Bug 131340 - Web Replay: memoize nondeterministic attributes of the Navigator interface
Summary: Web Replay: memoize nondeterministic attributes of the Navigator interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on: 131407
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-07 18:51 PDT by Brian Burg
Modified: 2014-04-11 15:01 PDT (History)
7 users (show)

See Also:

Attachments
the patchb (7.65 KB, patch)
2014-04-08 17:37 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-07 18:51:26 PDT 
These are easy to memoize, and this is a good layer to handle them at since different ports can do different things.

navigator.plugins and navigator.mimeTypes will be handled separately, since we can memoize the underlying call to Page::pluginData().
Comment 1 Brian Burg 2014-04-08 17:33:09 PDT 
This depends on code generator fix in 131407, but I'll upload the patch now anyway.
Comment 2 Brian Burg 2014-04-08 17:37:30 PDT 
Created attachment 228920 [details]
the patchb
Comment 3 WebKit Commit Bot 2014-04-11 15:01:33 PDT 
Comment on attachment 228920 [details]
the patchb

Clearing flags on attachment: 228920

Committed r167157: <http://trac.webkit.org/changeset/167157>
Comment 4 WebKit Commit Bot 2014-04-11 15:01:41 PDT 
All reviewed patches have been landed.  Closing bug.