Remove "System Font" from whitelisted DRT fonts and char width calculations
Created attachment 228922 [details]
Comment on attachment 228922 [details]
Rejecting attachment 228922 [details] from commit-queue.
Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 228922, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Full output: http://webkit-queues.appspot.com/results/5926285901561856
This change caused 300+ failures on Mountain Lion WK1 tester: <http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r167064%20(5110)/results.html>. Rolling out.
And yet EWS is all green? I am very surprised by this.
(In reply to comment #6)
> And yet EWS is all green? I am very surprised by this.
EWS uses Mountain Lion.
I have figured out what happened. There are two ways that the system font gets whitelisted in DRT, and this patch removes one and http://trac.webkit.org/changeset/167043 removes the other. This patch looks like the culprit because it was committed last. In my testing I hadn't tested the two patches on top of each other; only one after the other.
Created attachment 229064 [details]
Comment on attachment 229064 [details]
Clearing flags on attachment: 229064
Committed r167082: <http://trac.webkit.org/changeset/167082>
All reviewed patches have been landed. Closing bug.