WebKit doesn't properly honor the global user preferences for caption display in a few cases:
1. When a video starts playing, it should show captions if the user's preferences indicate a preference for caption display.
2. While a video is playing, captions should turn on/off as the user changes preferences.
3. Regardless of the user's preferences, if the user manually selects captions they should be displayed.
Created attachment 228653 [details]
Comment on attachment 228653 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=228653&action=review
> - m_captionDisplayMode = displayMode;
I needed to do this so that the "ForceOn" state was properly seen by system.
All tests (including uncommitted region tests) pass with this change.
(In reply to comment #4)
> All tests (including uncommitted region tests) pass with this change.
Additional test case, then?
(In reply to comment #5)
> (In reply to comment #4)
> > All tests (including uncommitted region tests) pass with this change.
> Additional test case, then?
after looking at it, I realize it's just a local copy of one of the Opera tests. I'm trying to get the whole set of them turned on in an upcoming patch.
Committed r166858: <http://trac.webkit.org/changeset/166858>