Bug 131258 – Honor System-Level User Preferences for Captions Display

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brent Fulgham]

WebKit doesn't properly honor the global user preferences for caption display in a few cases:

1. When a video starts playing, it should show captions if the user's preferences indicate a preference for caption display.
2. While a video is playing, captions should turn on/off as the user changes preferences.
3. Regardless of the user's preferences, if the user manually selects captions they should be displayed.

In all cases, the result of the following JavaScript should reflect what's going on in the video playback:

document.querySelector("video").webkitClosedCaptionsVisible

[Brent Fulgham]

<rdar://problem/15745400>
<rdar://problem/15745452>

[Brent Fulgham]

Created attachment 228653 [details]
Patch

[Brent Fulgham]

Comment on attachment 228653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228653&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:-3713
> -        m_captionDisplayMode = displayMode;

I needed to do this so that the "ForceOn" state was properly seen by system.

[Brent Fulgham]

All tests (including uncommitted region tests) pass with this change.

[Jon Lee]

(In reply to comment #4)
> All tests (including uncommitted region tests) pass with this change.

Additional test case, then?

[Brent Fulgham]

(In reply to comment #5)
> (In reply to comment #4)
> > All tests (including uncommitted region tests) pass with this change.
> 
> Additional test case, then?

after looking at it, I  realize it's just a local copy of one of the Opera tests. I'm trying to get the whole set of them turned on in an upcoming patch.

[Brent Fulgham]

Committed r166858: <http://trac.webkit.org/changeset/166858>