Bug 131344 - Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
Summary: Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on: 131258
  Show dependency treegraph
Reported: 2014-04-07 20:52 PDT by Brent Fulgham
Modified: 2014-04-08 09:02 PDT (History)
10 users (show)

See Also:

Patch (1.65 KB, patch)
2014-04-07 20:56 PDT, Brent Fulgham
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-04-07 20:52:00 PDT
The caption user preferences can be configured so that captions are always displayed. When this happens, we need to make sure that the JS API for 'webkitClosedCaptionsVisible' correctly reflects the state of this setting. If captions are being displayed on the page, 'webkitClosedCaptionsVisible' must indicate true. Likewise, if captions are hidden it should return false.

Bug 131258 dealt with the state of 'webkitClosedCaptionsVisible' when changes were made to the user preferences. However, an edge condition at initial load of a webpage was not properly handled. This bug corrects that additional case.
Comment 1 Brent Fulgham 2014-04-07 20:52:21 PDT
Comment 2 Brent Fulgham 2014-04-07 20:56:04 PDT
Created attachment 228799 [details]
Comment 3 Brent Fulgham 2014-04-08 09:02:05 PDT
Committed r166927: <http://trac.webkit.org/changeset/166927>