WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 131344
Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
https://bugs.webkit.org/show_bug.cgi?id=131344
Summary
Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
Brent Fulgham
Reported
2014-04-07 20:52:00 PDT
The caption user preferences can be configured so that captions are always displayed. When this happens, we need to make sure that the JS API for 'webkitClosedCaptionsVisible' correctly reflects the state of this setting. If captions are being displayed on the page, 'webkitClosedCaptionsVisible' must indicate true. Likewise, if captions are hidden it should return false.
Bug 131258
dealt with the state of 'webkitClosedCaptionsVisible' when changes were made to the user preferences. However, an edge condition at initial load of a webpage was not properly handled. This bug corrects that additional case.
Attachments
Patch
(1.65 KB, patch)
2014-04-07 20:56 PDT
,
Brent Fulgham
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-04-07 20:52:21 PDT
<
rdar://problem/15745400
>
Brent Fulgham
Comment 2
2014-04-07 20:56:04 PDT
Created
attachment 228799
[details]
Patch
Brent Fulgham
Comment 3
2014-04-08 09:02:05 PDT
Committed
r166927
: <
http://trac.webkit.org/changeset/166927
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug