Bug 131194 – [Win] Load Media Controls js/css from bundle

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brent Fulgham]

We can load the mediaControls*.{js,css} files from the bundle, rather than inserting encoding versions into the C source code on Windows, just like we can for Mac/iOS.

[Brent Fulgham]

Created attachment 228578 [details]
Patch

[Dean Jackson]

Comment on attachment 228578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:7092
> +    <ClCompile Include="..\platform\DisplaySleepDisabler.cpp" />
> +    <ClCompile Include="..\platform\SystemSleepListener.cpp" />

There are a lot of changes to this file, but I assume it's either unintentional and you'll remove it, or intentional and you know what you are doing!

> Source/WebCore/rendering/RenderThemeSafari.h:188
> +    bool m_mediaControlsScriptLoaded;
> +    bool m_mediaControlsStyleSheetLoaded;

There was a followup commit where I skipped the booleans and just checked if the string was empty.

> Source/WebCore/rendering/RenderThemeWin.cpp:1117
> +    // Open the file

Nit: end with .

[Brent Fulgham]

Comment on attachment 228578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review

>> Source/WebCore/rendering/RenderThemeWin.cpp:1117
>> +    // Open the file
> 
> Nit: end with .

Even better -- why have this stupid comment at all!?!  :-)

[Brent Fulgham]

Comment on attachment 228578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review

>> Source/WebCore/rendering/RenderThemeWin.cpp:1117
>> +    // Open the file
> 
> Nit: end with .

Even better -- why have this stupid comment at all!?!  :-)

[Brent Fulgham]

Committed r166782: <http://trac.webkit.org/changeset/166782>